Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unecessary lint #[allow(...)] #12983

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Remove unecessary lint #[allow(...)] #12983

merged 1 commit into from
Apr 22, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Apr 15, 2024 •
edited
Loading

Objective

Solution

  • Remove unecessary allow attribute
    • This is currently blocked until Rust beta updates.
    • Last tested with rustc 1.78.0-beta.7 (6fd191292 2024-04-12).

@BD103 BD103 added A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change S-Blocked This cannot move forward until something else changes labels Apr 15, 2024
@BD103 BD103 marked this pull request as ready for review April 22, 2024 02:12
@BD103 BD103 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Blocked This cannot move forward until something else changes labels Apr 22, 2024
@BD103
Copy link
Member Author

BD103 commented Apr 22, 2024

A new Rust beta has been released (rustc 1.78.0-beta.8 (13ef05e2b 2024-04-19)), so this PR is finally unblocked! I think this is a trivial change, so I'm marking this as ready for final review.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 22, 2024
Merged via the queue into bevyengine:main with commit a502236 Apr 22, 2024
28 checks passed
@BD103 BD103 deleted the rm-lint branch April 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unecessary lint
3 participants
@BD103 @james7132 @alice-i-cecile