Clean up 2d render phases #12982
Merged
Clean up 2d render phases #12982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
added
A-Rendering
IceSentry
force-pushed
the
2d-phases-cleanup
branch
3 times, most recently
from
ace2d1e
to
df23a13
Compare
IceSentry
force-pushed
the
2d-phases-cleanup
branch
from
75131d7
to
ddba1fd
Compare
kristoff3r
approved these changes
May 1, 2024
crates/bevy_core_pipeline/src/core_2d/main_transparent_pass_2d_node.rs
Outdated
Show resolved
Hide resolved
jgayfer
approved these changes
May 1, 2024
10 tasks
IceSentry
added
the
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
This PR is based on top of #12982 # Objective - Mesh2d currently only has an alpha blended phase. Most sprites don't need transparency though. - For some 2d games it can be useful to have a 2d depth buffer ## Solution - Add an opaque phase to render Mesh2d that don't need transparency - This phase currently uses the `SortedRenderPhase` to make it easier to implement based on the already existing transparent phase. A follow up PR will switch this to `BinnedRenderPhase`. - Add a 2d depth buffer - Use that depth buffer in the transparent phase to make sure that sprites and transparent mesh2d are displayed correctly ## Testing I added the mesh2d_transforms example that layers many opaque and transparent mesh2d to make sure they all get displayed correctly. I also confirmed it works with sprites by modifying that example locally. --- ## Changelog - Added `AlphaMode2d` - Added `Opaque2d` render phase - Camera2d now have a `ViewDepthTexture` component ## Migration Guide - `ColorMaterial` now contains `AlphaMode2d`. To keep previous behaviour, use `AlphaMode::BLEND`. If you know your sprite is opaque, use `AlphaMode::OPAQUE` ## Follow up PRs - See tracking issue: #13265 --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Christopher Biscardi <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
Based on top of #12982 and #13069 # Objective - Opaque2d was implemented with SortedRenderPhase but BinnedRenderPhase should be much faster ## Solution - Implement BinnedRenderPhase for Opaque2d ## Notes While testing this PR, before the change I had ~14 fps in bevymark with 100k entities. After this change I get ~71 fps, compared to using sprites where I only get ~63 fps. This means that after this PR mesh2d with opaque meshes will be faster than the sprite path. This is not a 1 to 1 comparison since sprites do alpha blending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently, the 2d pipeline only has a transparent pass that is used for everything. I want to have separate passes for opaque/alpha mask/transparent meshes just like in 3d.
This PR does the basic work to start adding new phases to the 2d pipeline and get the current setup a bit closer to 3d.
Solution
ViewNodeforMainTransparentPass2dNodeNode2d::StartMainPass,Node2d::EndMainPassChangelog
Node2d::StartMainPass,Node2d::EndMainPassMigration Guide
If you were using
Node2d::MainPassto order your own custom render node. You now need to order it relative toNode2d::StartMainPassorNode2d::EndMainPass.