Use BinnedRenderPhase for Opaque2d #13091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
added
A-Rendering
10 tasks
|
waiting on #13069 to be merged so I can clean up this PR |
IceSentry
added
the
S-Blocked
|
@IceSentry should I hold off on reviewing until you've cleaned up, or will the cleaning be minor? |
|
This will require enough work to patch that I might need to create a new PR. We'll have to wait on the other PR being merged to see. |
IceSentry
force-pushed
the
opaque2d-binned-render-phase
branch
from
2e53c8f
to
69e5fa4
Compare
|
@jgayfer this should be ready to review now |
IceSentry
removed
the
S-Blocked
tychedelia
approved these changes
Aug 7, 2024
tychedelia
added
the
S-Needs-Review
kristoff3r
approved these changes
Aug 7, 2024
tychedelia
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #12982 and #13069
Objective
Solution
Notes
While testing this PR, before the change I had ~14 fps in bevymark with 100k entities. After this change I get ~71 fps, compared to using sprites where I only get ~63 fps. This means that after this PR mesh2d with opaque meshes will be faster than the sprite path. This is not a 1 to 1 comparison since sprites do alpha blending.