Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable gpu preprocessing on android with Adreno 730 GPU and earilier #14176

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

Litttlefish
Copy link
Contributor

@Litttlefish Litttlefish commented Jul 6, 2024

Objective

Fix #14146

Solution

Expansion of #13323 , excluded Adreno 730 and earlier.

Testing

Tested on android device(Adreno 730) that used to crash

@eero-lehtinen
Copy link
Contributor

This limits too much because 740 is proven to work #13323 (comment), and 750 works for me.

@Litttlefish Litttlefish changed the title disable gpu preprocessing on android with Adreno 7xx GPU disable gpu preprocessing on android with Adreno 730 GPU Jul 6, 2024
@Litttlefish
Copy link
Contributor Author

This limits too much because 740 is proven to work #13323 (comment), and 750 works for me.

I've changed it to only disble on 6xx and 730 now

@eero-lehtinen
Copy link
Contributor

eero-lehtinen commented Jul 6, 2024

There are also 702, 710, 720, 725 that I think are safe to assume don't work either because they are older.
732 and 735 probably don't either.
https://en.wikipedia.org/wiki/Adreno#Adreno_700_series

@eero-lehtinen
Copy link
Contributor

So I would check that the second number is 3 or less.

@Litttlefish Litttlefish changed the title disable gpu preprocessing on android with Adreno 730 GPU disable gpu preprocessing on android with Adreno 730 GPU and earilier Jul 6, 2024
@Litttlefish
Copy link
Contributor Author

Litttlefish commented Jul 6, 2024

So I would check that the second number is 3 or less.

My assumption is GPU earlier than 730(probably, since there Adreno 740 is used for 8Gen2 series) doesn't support it, so I used this for now

But Adreno number naming is not that simple, like 720 is used in 7Gen3, which probably should support it(newer), while 725 used in 7Gen2 is the same to 730 with lower frequency🤔needs more testing to confirm

@eero-lehtinen
Copy link
Contributor

Yeah looks like 732 and 735 are very new as well

@Litttlefish
Copy link
Contributor Author

Yeah looks like 732 and 735 are very new as well

Anyways I excluded 720, since it probably supports gpu preprocessing, I'll let it for others to test

@mockersf mockersf added this to the 0.14.1 milestone Jul 6, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen O-Android Specific to the Android mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash labels Jul 7, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 8, 2024
Merged via the queue into bevyengine:main with commit 2d34226 Jul 8, 2024
32 checks passed
@Litttlefish Litttlefish deleted the adreno-fix branch July 8, 2024 01:45
mockersf pushed a commit that referenced this pull request Aug 2, 2024
…#14176)

# Objective

Fix #14146 

## Solution

Expansion of #13323 , excluded Adreno 730 and earlier.

## Testing

Tested on android device(Adreno 730) that used to crash
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
# Objective

The Android example on Adreno 642L currently crashes on startup.

Previous PRs #14176 and #13323 have adressed this specific crash
occurring on some Adreno GPUs, that fix works as it should but isn't
applied when to the GPU name contains a suffix like in the case of
`642L`.

## Solution

- Amending the logic to filter out any parts of the GPU name not
containing digits thus enabling the fix on `642L`.

## Testing

- Ran the Android example on a Nothing Phone 1. Before this change it
crashed, after it works as intended.

---------

Co-authored-by: Sam Pettersson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior O-Android Specific to the Android mobile operating system P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Android on 0.14
4 participants