-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable gpu preprocessing on android with Adreno 730 GPU and earilier #14176
Conversation
This limits too much because 740 is proven to work #13323 (comment), and 750 works for me. |
I've changed it to only disble on 6xx and 730 now |
There are also 702, 710, 720, 725 that I think are safe to assume don't work either because they are older. |
So I would check that the second number is 3 or less. |
My assumption is GPU earlier than 730(probably, since there Adreno 740 is used for 8Gen2 series) doesn't support it, so I used this for now But Adreno number naming is not that simple, like 720 is used in 7Gen3, which probably should support it(newer), while 725 used in 7Gen2 is the same to 730 with lower frequency🤔needs more testing to confirm |
Yeah looks like 732 and 735 are very new as well |
Anyways I excluded 720, since it probably supports gpu preprocessing, I'll let it for others to test |
# Objective The Android example on Adreno 642L currently crashes on startup. Previous PRs #14176 and #13323 have adressed this specific crash occurring on some Adreno GPUs, that fix works as it should but isn't applied when to the GPU name contains a suffix like in the case of `642L`. ## Solution - Amending the logic to filter out any parts of the GPU name not containing digits thus enabling the fix on `642L`. ## Testing - Ran the Android example on a Nothing Phone 1. Before this change it crashed, after it works as intended. --------- Co-authored-by: Sam Pettersson <[email protected]>
Objective
Fix #14146
Solution
Expansion of #13323 , excluded Adreno 730 and earlier.
Testing
Tested on android device(Adreno 730) that used to crash