Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable gpu preprocessing on android with Adreno 730 GPU and earilier #14176

Merged
merged 8 commits into from
Jul 8, 2024
Merged
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/bevy_render/src/batching/gpu_preprocessing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,14 @@ impl FromWorld for GpuPreprocessingSupport {
let device = world.resource::<RenderDevice>();

if device.limits().max_compute_workgroup_size_x == 0 ||
// filter lower end / older devices on Android as they crash when using GPU preprocessing
(cfg!(target_os = "android") && adapter.get_info().name.starts_with("Adreno (TM) 6"))
// filter some Qualcomm devices on Android as they crash when using GPU preprocessing
(cfg!(target_os = "android") && {
let name = adapter.get_info().name;
// filter out Adreno 730 and earlier GPUs (except 720, it's newer than 730)
name.strip_prefix("Adreno (TM) ").is_some_and(|version|
version != "720" && version.parse::<u16>().unwrap() <= 730
Litttlefish marked this conversation as resolved.
Show resolved Hide resolved
Litttlefish marked this conversation as resolved.
Show resolved Hide resolved
)
})
{
GpuPreprocessingSupport::None
} else if !device
Expand Down