Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua Select API, Lua based KeySelect & Customisable Smart Select #3757

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Lua Select API, Lua based KeySelect & Customisable Smart Select #3757

wants to merge 40 commits into from
+1,027 −8

Commits on Jul 6, 2024

  1. first pass - hard coded options for air/notair/builder

    @whossname
    whossname committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    d54c60e View commit details
    Browse the repository at this point in the history

  2. fix airFilter, custom placeholder

    @whossname
    whossname committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    52c9621 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. wip - custom filter

    @whossname
    whossname committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    941213f View commit details
    Browse the repository at this point in the history

  2. working prototype

    @whossname
    whossname committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    3efbc66 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'more_selectbox_options'

    @whossname
    whossname committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    18db210 View commit details
    Browse the repository at this point in the history

  4. rough attempt at the easier rules, remove unnecessary aircraft filter

    @whossname
    whossname committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    7c05fb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. implement rules that don't have arguments 

    includes a refactor of the rule api - now receives udef, udefid, uid instead of just udefid
    @whossname
    whossname committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    b490b6d View commit details
    Browse the repository at this point in the history

  2. slight reordering/grouping of rules

    @whossname
    whossname committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    776013b View commit details
    Browse the repository at this point in the history

  3. implementing the last rules

    @whossname
    whossname committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    22fbc06 View commit details
    Browse the repository at this point in the history

  4. bug fixes

    @whossname
    whossname committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    5009fb0 View commit details
    Browse the repository at this point in the history

  5. fix cmd rules, comment out category

    @whossname
    whossname committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    c0ea245 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. rename customFilter to customRulesFilter, add customRulesLookup 

    instead of parsing the rules on each button press, now it does it once and stores the rules in a lookup table
    @whossname
    whossname committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    0ac8cc4 View commit details
    Browse the repository at this point in the history

  2. add AntiAir rule

    @whossname
    whossname committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    009cd6e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'more_selectbox_options'

    @whossname
    whossname committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    a3177d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. separate select api from unit_smart_select

    @whossname
    whossname committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    b996f98 View commit details
    Browse the repository at this point in the history

  2. basic test, better select api function names

    @whossname
    whossname committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    1799e86 View commit details
    Browse the repository at this point in the history

  3. better test error messages, debugging tests, fix Idel, improve Builder

    @whossname
    whossname committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    dc1b364 View commit details
    Browse the repository at this point in the history

  4. refactor repeating code unitPassesFilterRules, comment how to run tests

    @whossname
    whossname committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    80ded54 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. isBuilder includes carrier ships, refactor createUnits function in test

    @whossname
    whossname committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    f32d0ea View commit details
    Browse the repository at this point in the history

  2. implement category rule

    @whossname
    whossname committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    7b54995 View commit details
    Browse the repository at this point in the history

  3. test unit groups properly, count units selected, reorder ruledefs

    @whossname
    whossname committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    37f1820 View commit details
    Browse the repository at this point in the history

  4. implement InPrevSel. Needed to test spring after api for Not_InPrevSel

    @whossname
    whossname committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    ad31efd View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. replace "rules" with "filter" to match api definitions

    @whossname
    whossname committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    661e25e View commit details
    Browse the repository at this point in the history

  2. prep for apiCommand - refactor out applyApiFn and compare in test

    @whossname
    whossname committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    f4a44d5 View commit details
    Browse the repository at this point in the history

  3. basic idea for command and source

    @whossname
    whossname committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    884f55f View commit details
    Browse the repository at this point in the history

  4. basic command implementation. tests finding odd errors

    @whossname
    whossname committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    c46bbb2 View commit details
    Browse the repository at this point in the history

  5. debugging

    @whossname
    whossname committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    7747b25 View commit details
    Browse the repository at this point in the history

  6. fix source, ignore more weirdness in the test

    @whossname
    whossname committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    ab0ac1a View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. move types to select_api, localise most used Spring functions

    @whossname
    whossname committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b27674b View commit details
    Browse the repository at this point in the history

  2. first pass unit_key_select module and wip select conclusion

    @whossname
    whossname committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2a6202e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. tests and some fixes for full commands. seeing some odd results

    @whossname
    whossname committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    560a3a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. remove command counts, use circular array index instead

    @whossname
    whossname committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    9d94ccf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'split_select_engine'

    @whossname
    whossname committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0f6f9ea View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. override select instead of using keyselect

    @whossname
    whossname committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e5c7d69 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. hotfix - throw errors on invalid tokens

    @whossname
    whossname committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    af86f62 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. disable KeySelect by default, NameContains uses translatedHumanName

    @whossname
    whossname committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0bb0342 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'beyond-all-reason:master' into master

    @whossname
    whossname authored Sep 22, 2024
    Configuration menu
    Copy the full SHA
    59989d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. remove unwanted return type, set sensible layer

    @whossname
    whossname committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0651a57 View commit details
    Browse the repository at this point in the history

  2. revert white space changes

    @whossname
    whossname committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    c665c1b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. addressing PR feedback 

    - use global `CMD` and `UnitDefNames` lookups
- use `split` string function
- use localized `spGetSelectedUnits`
- handle abbreviations
- remove dead code
- `getAlreadySelectedSet` as a local function
- removed unused parameter from `parseConclusion`
- fix hard coded 50% in `SelectPart_` conclusion
- fix `x` not validated in `FromMouse` conclusion
    @whossname
    whossname committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    dbff2d3 View commit details
    Browse the repository at this point in the history