-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrections to remove double suffix in _coordsystem.jon #183
Conversation
…ordsystem.json reference to this surface
@@ -1,8 +1,8 @@ | |||
{ | |||
"IntendedFor": "/derivatives/surfaces/sub-bp/ses-01/anat/sub-bp_T1w_pial.surf.gii", | |||
"IntendedFor": "/derivatives/surfaces/sub-bp/ses-01/anat/sub-bp_pial.surf.gii", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, as cited in bids-standard/bids-specification#463 (comment) _desc-T1w
is current recommended by BEP003 way to annotate the source "suffix" (modality), which could come handy here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yarikoptic that will be a good option! Should I implement the _desc-T1w here already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one one hand: If examples should follow stock BIDS, then I guess _desc-
better waits for common derivatives to be merged. BUT because stock BIDS I believe pretty much allows anything to fall under derivatives/
subfolders -- you could as well add it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If examples should follow stock BIDS, then I guess _desc- better waits for common derivatives to be merged
I agree
BUT because stock BIDS I believe pretty much allows anything to fall under derivatives/ subfolders -- you could as well add it
I think so too :-)
I just updated this pull request with the _desc-T1w tag as suggested by @yarikoptic |
These corrections remove the double suffix in the derivatives surfaces and in the _coordsystem.json reference to this surface.
Aligns with pull request on bids-standard ENH: tune suggested naming for the surface to follow BEP011 bids-standard/bids-specification#463