-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add participants.json with Levels as objects #413
Conversation
@surchs I may need your help on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting this issue:
1: [ERR] Invalid JSON file. The file is not formatted according the schema. (code: 55 - JSON_SCHEMA_VALIDATION_ERROR)
./participants.json
Evidence: ['sex'].Levels['F'] should be string
./participants.json
Evidence: ['sex'].Levels['M'] should be string
./participants.json
Evidence: ['sex'].TermURL should match format "uri"
So we probably need to tell the (legacy JS) validator / the schema that levels as objects are fine (not only string)
And we furthermore need to add TermURLs for:
- age
- sex
- female
- male
- Hispanic
- MiddleEastern
- Caucasian/African/NativeSouthAmerican
- Caucasian
- Asian/Caucasian
- Asian
- Right
- Left
- Handedness
- dominant_hand
- gender
Hey folks! I think the variables listed by @sappelhoff fall into two levels with different answered by the TermURL:
there are a ton of possible TermURLs for either, but I think it's a good idea to pick the TermURLs for values about the same concept from the same list. For example this could be a list:
What ontology to pick terms from is probably a bit beyond what BIDS can do in the examples / recommendations. But maybe we can provide some rule-of-thumb, i.e.: take from a list that is actively maintained, ideally widely used, ... |
"TermURL": "http://purl.obolibrary.org/obo/PATO_0001894", | ||
"Levels": { | ||
"D": { | ||
"Description": "D" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed "TermURL" here for now. If somebody knows what this means, please feel free to clarify.
Okay:
Will merge. Thanks for the start @Remi-Gau and thanks for the support @surchs! EDIT and of course thanks to @effigies for adding validator support. |
closes #412