[SCHEMA] MRS schema updates #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
added
BEP
schema
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bep022 #1830 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 16 16
Lines 1380 1380
=======================================
Hits 1215 1215
Misses 165 165 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
schema/mrs_header
branch
from
f6cd503
to
d300416
Compare
effigies
commented
May 29, 2024
effigies
changed the title
This implements the following agreed upon suggestions: * Set InversionTime to recommended if `inv` entity is present. (`entities.inversion`) * Move to RepetitionTime and VolumeTiming, rather than RepetitionTime as an array in the variable-timing case. * ReferenceSignal should be uniformly recommended.
effigies
force-pushed
the
schema/mrs_header
branch
from
d300416
to
83c6f3e
Compare
effigies
added
the
exclude-from-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markmikkelsen Here is the PR I promised in #1377 (comment). A bit ahead of schedule.
@rwblair Heads up that we need to add this to the validator. We're going to need to make sure our NIfTI reader can handle NIfTI-2 and header extensions.