Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCHEMA] MRS schema updates #1830

Merged
merged 7 commits into from
Jun 1, 2024
Merged

[SCHEMA] MRS schema updates #1830

merged 7 commits into from
Jun 1, 2024

Commits on May 31, 2024

  1. SCHEMA: Add nifti_header.mrs to context

    @effigies
    effigies committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f6e3f72 View commit details
    Browse the repository at this point in the history

  2. SCHEMA: Add check for consistency between MRS header and sidecar

    @effigies
    effigies committed May 31, 2024
    Configuration menu
    Copy the full SHA
    899e6ec View commit details
    Browse the repository at this point in the history

  3. Split conditional matrices in schema, combine in doc 

    This implements the following agreed upon suggestions:

* Set InversionTime to recommended if `inv` entity is present.
  (`entities.inversion`)
* Move to RepetitionTime and VolumeTiming, rather than RepetitionTime
  as an array in the variable-timing case.
* ReferenceSignal should be uniformly recommended.
    @effigies
    effigies committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9dabf8e View commit details
    Browse the repository at this point in the history

  4. Make BodyPart(Details) required if voi entity is present

    @effigies
    effigies committed May 31, 2024
    Configuration menu
    Copy the full SHA
    07d2ec8 View commit details
    Browse the repository at this point in the history

  5. feat(checks): Add check to ensure MatrixSize and nifti_header.dim are… 

    … consistent
    @effigies
    effigies committed May 31, 2024
    Configuration menu
    Copy the full SHA
    0181150 View commit details
    Browse the repository at this point in the history

  6. fix(checks): Use non-trivial expressions for selectors

    @effigies
    effigies committed May 31, 2024
    Configuration menu
    Copy the full SHA
    83c6f3e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Uncombine required/recommended/optional fields

    @effigies
    effigies committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1d5e089 View commit details
    Browse the repository at this point in the history