Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP mdBook #22

Closed
wants to merge 4 commits into from
Closed

WIP mdBook #22

wants to merge 4 commits into from

Conversation

teonbrooks
Copy link
Collaborator

closes #18. here's a proof of concept of mdBook rendered here.

@teonbrooks
Copy link
Collaborator Author

cc: @chrisfilo

@teonbrooks teonbrooks force-pushed the mdBook branch 2 times, most recently from 93a6477 to 89bb6ac Compare October 2, 2018 05:46
@chrisgorgo
Copy link
Contributor

That's an awesome proof of concept. Thanks for sharing.

@choldgraf do you have some experience with such solutions? WDYT?

@choldgraf
Copy link
Collaborator

very cool! the general layout is very similar to what we've been doing w/ Jekyll textbooks (here's an example texbook: https://www.textbook.ds100.org/)

I'm +0 on choosing a specific build system.

On the one hand, mdbook has first class support for "book" structures. On the other, it uses Rust which is an awesome tool/community, but is very unfamiliar to the scientific analytics community.

On the one hand, Jekyll is fairly familiar and has first-class github support, on the other, it's not "designed" to host books etc.

One potential difference is the templating engine used under the hood...does mdbooks use liquid?

@choldgraf
Copy link
Collaborator

also @teonbrooks - what's the closest "standard" license to the mozilla public license? Is it basically MIT?

@chrisgorgo
Copy link
Contributor

It uses handlebars for templating - see https://rust-lang-nursery.github.io/mdBook/format/theme/index.html for details.

I think we should move fast with splitting the document and adopting a framework (we already have people sending content based PRs). mdbook seems to be easy to implement - are there any red flags?

@teonbrooks
Copy link
Collaborator Author

also @teonbrooks - what's the closest "standard" license to the mozilla public license? Is it basically MIT?

I think the closest would be in fact MIT but don't quite. MPL is a very permissive license from my understanding.

@teonbrooks
Copy link
Collaborator Author

I think we should move fast with splitting the document and adopting a framework (we already have people sending content based PRs). mdbook seems to be easy to implement - are there any red flags?

I agree. I think it would make build a static site easy and it would make diffing even easier and clearer.

@choldgraf
Copy link
Collaborator

as long as MPL is basically MIT, then I'm +1 on mdbook. My biggest concern is maintainability from a community that mostly doesn't use Rust, but if the templating is straightforward then I'm happy w/ it

@teonbrooks
Copy link
Collaborator Author

teonbrooks commented Oct 3, 2018

found this blogpost about the MPL license.

tl;dr: all the things outside of the mdBook project can be whatever license we select (MIT CC-BY likely). if we modify the source code of mdBook, then the changes go back to the project under the MPL. it's seen as win-win for everyone 🎉

@choldgraf
Copy link
Collaborator

@teonbrooks one thing I think we should do if we use mdBook is write up some dev docs so that others in the community know how the general build system works. Does that sound reasonable?

@teonbrooks
Copy link
Collaborator Author

@choldgraf yes, agreed. I think we should make it a separate PR bc I think the restructuring from the monolithic specification to sections should happen soon especially since people are turning their eyes to the repo

@chrisgorgo
Copy link
Contributor

+1 also #18 (comment)

@choldgraf
Copy link
Collaborator

+1 on a separate PR.

@teonbrooks teonbrooks changed the title WIP mdBook Discussion of mdBook, mkdoc, sphinx, etc. Oct 3, 2018
@teonbrooks teonbrooks changed the title Discussion of mdBook, mkdoc, sphinx, etc. WIP mdBook Oct 3, 2018
@teonbrooks
Copy link
Collaborator Author

closing this pr for now to hash out discussion on #18. we've separated out the md splitting (#28) from the rendering engine

@teonbrooks teonbrooks closed this Oct 3, 2018
@teonbrooks
Copy link
Collaborator Author

we can re-open this if we decide to go the way of mdBook

franklin-feingold added a commit that referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possibly use mdBook to render md files online
3 participants