-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] split intro, commons, mr, and meg into directory from specification.md #28
Conversation
WIP: MR is currently a composite mr.md. Needs to be sectioned off.
Thanks for submitting this. We just had a brainstorming session with @franklin-feingold and @JesseyWright about this and came up with the following splitting
Please note that numbering has changed and some sections were moved around. Would love to hear what you think. |
yeah, that makes sense, fewer files overall and still compartmentalized. I guess one thing would be to use native md section, subsection nomenclature internally. that way there won't be any conflicting section numbers. we can then implement anchor tags to refer to sections internally |
That's the idea - with each md file (independent of where it is in the hierarchy) starting with As for section numbers. Do you think we should remove them completely and trust they will be handled by whatever rendering engine we will use? They seem to be handy when talking about different parts of the spec (although anchors will help with that a lot). |
i guess it depends on whether there could be hierarchical changes to the doc. If it is stable from here on then it would be fine to include. It would be a matter of having the rendering engine turn off auto-gen section headers then. also, i think if we ever wanted to include something at the folder level, e.g. in the case of modality specific files, I read that the README is rendered at the top of the folder section. just fyi. |
would it be worth considering markdown with sphinx? as of recent versions, sphinx supports markdown. this means readthedocs will be able to automatically generate the documentation. this should also allow sectioning, and contributions to specific files, possibly making the aggregation easier. |
I don't see clear benefits (or disadvantages), but lets discuss at #18. This PR concerns splitting the markdown document |
src/02_common_principles.md
Outdated
Directory structure | ||
------------------- | ||
|
||
### 1 Single session example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section has a number, but some others don't. I would either remove all of them or add them everywhere.
@chrisfilo - i think splitting is always cleaner, more atomic the better for maintenance/updates/review, but then stitching becomes the issue. if stitching exists, then different forms of splitting becomes easier. that's the only reason i brought up the stitcher in the context of the splitter. |
I believe there is no disagreement that the markdown will be rendered into a more palatable form (although probably not just stitched into a single large file). There is the only discussion on which framework to use to do the rendering. All of them can work with the file/folder structure in this repo so I think we are good to merge. Thank you @teonbrooks! |
@chrisfilo I saved the deletion the monolithic file for you ;) |
closes #4
WIP: MR is currently a composite mr.md. Needs to be sectioned off.