Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP 18 suggestions #398

Merged
merged 8 commits into from
Feb 3, 2020
Merged

Conversation

effigies
Copy link
Collaborator

When this is ready to merge, please squash or rebase, so we don't bother polluting the changelog.

Suggestions:

  1. Replace bullets with sentences.
  2. Language updates for consistency with common-derivatives.
  3. Typo fixes (e.g., Connectom -> Connectome)
  4. Make examples more specific and conformant to required types

@effigies
Copy link
Collaborator Author

@claramoreau9 I'm unable to request a review from you, but assuming you're the extension developer, I would appreciate your eyes.

Copy link
Collaborator

@CPernet CPernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for me except genetic_info.json - why removing the multiple entries, I do want to show that multiple info can be entered ; and indeed it is often the case that different analytics are provided

@effigies
Copy link
Collaborator Author

Cyril, I'm not sure what you mean about removing multiple entries. I don't think I changed anything in that respect. Could you show how you would like it to read?

@CPernet
Copy link
Collaborator

CPernet commented Jan 31, 2020

it's me who read to quickly, you only changed to have to the next line ... sorry
anyway in the UK bb example (not finished, I know sorry) we wote:

"AnalyticalApproach": ["Whole Genome Sequencing","SNP/CNV Genotypes"],

I think it's better, showing multiple options -- is that correct to use the square brackets and list items?
Maybe we should do that here too.
thx

FYI: https://github.com/CPernet/bids-examples/tree/master/genetics_ukbb

@effigies effigies merged commit b27e3d5 into bids-standard:bep018 Feb 3, 2020
@effigies effigies deleted the bep18/suggestions branch February 3, 2020 17:50
@CPernet
Copy link
Collaborator

CPernet commented Feb 6, 2020

are we good on that one now? anything i need to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants