Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add links to example datasets for each modality #845

Merged
merged 15 commits into from
Nov 11, 2021

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Aug 6, 2021

Fixes #842

Add links to example from the BIDS example repo in the following section:

  • MEG
  • iEEG
  • genetics
  • PET
  • MRI
    • anat
    • func
    • dwi
    • fmap
    • asl
    • qmri
  • behavior ?
  • physio

@Remi-Gau
Copy link
Collaborator Author

While working on this I am tempted to split the table in the README of BIDS-example to match better with the BEP:
https://github.com/bids-standard/bids-examples#dataset-index

  • get the PET example out of the multomodal table
  • get the qMRI and the ASL examples out of the MRI dataset and in their own respective tables

I would be easier to then have a single link to those sub-tables in the spec, than a whole list of links in the spec. Also this way we can add more examples in BIDS example without having to do the same in the spec.

@sappelhoff
Copy link
Member

I am tempted to split the table in the README of BIDS-example to match better with the BEP

Sounds good to me - perhaps also a nice opportunity to resolve bids-standard/bids-examples#224 (or close it in favor of your alternative solution)

@Remi-Gau
Copy link
Collaborator Author

I am tempted to split the table in the README of BIDS-example to match better with the BEP

Sounds good to me - perhaps also a nice opportunity to resolve bids-standard/bids-examples#224 (or close it in favor of your alternative solution)

Let me start tackling this one too.

@Remi-Gau Remi-Gau removed the request for review from chrisgorgo October 18, 2021 14:06
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Remi.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@sappelhoff sappelhoff merged commit 530432b into bids-standard:master Nov 11, 2021
@Remi-Gau Remi-Gau deleted the add_examples branch November 15, 2021 05:26
@mariehbourget mariehbourget mentioned this pull request Nov 16, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to specific bids-example in the specification
3 participants