add EEGLAB as a valid keyword for EEG coordsystems (#1268)

* add EEGLAB as a valid keyword for EEG coordsystems * add EEGLAB-HJ * Apply suggestions from code review
bids-standard · Apr 30, 2021 · e9763df · e9763df
1 parent 0bbc08f
commit e9763df
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 16 deletions.
diff --git a/bids-validator/bids_validator/rules/file_level_rules.json b/bids-validator/bids_validator/rules/file_level_rules.json
@@ -323,6 +323,8 @@
       "@@@_eeg_space_@@@": [
         "Other",
         "CapTrak",
+        "EEGLAB",
+        "EEGLAB-HJ",
         "CTF",
         "ElektaNeuromag",
         "4DBti",

diff --git a/bids-validator/bids_validator/rules/session_level_rules.json b/bids-validator/bids_validator/rules/session_level_rules.json
@@ -35,11 +35,7 @@
   "pet_ses": {
     "regexp": "^[\\/\\\\](sub-[a-zA-Z0-9]+)[\\/\\\\](?:(ses-[a-zA-Z0-9]+)[\\/\\\\])?\\1(_\\2)?(?:_trc-[a-zA-Z0-9]+)?(?:_rec-[a-zA-Z0-9]+)?(?:_task-[a-zA-Z0-9]+)?(?:_run-[0-9]+_)?(@@@_pet_ses_type_@@@)$",
     "tokens": {
-      "@@@_pet_ses_type_@@@": [
-        "_pet.json",
-        "_events.json",
-        "_events.tsv"
-      ]
+      "@@@_pet_ses_type_@@@": ["_pet.json", "_events.json", "_events.tsv"]
     }
   },
 
@@ -102,6 +98,8 @@
       "@@@_eeg_space_@@@": [
         "Other",
         "CapTrak",
+        "EEGLAB",
+        "EEGLAB-HJ",
         "CTF",
         "ElektaNeuromag",
         "4DBti",

diff --git a/bids-validator/validators/json/schemas/common_definitions.json b/bids-validator/validators/json/schemas/common_definitions.json
@@ -4,10 +4,20 @@
     "CogAtlasID": { "type": "string", "format": "uri" },
     "CogPOID": { "type": "string", "format": "uri" },
     "CoordUnits": { "type": "string", "enum": ["m", "mm", "cm", "n/a"] },
-    "MEGCoordSys": { "type": "string", "enum": ["CTF", "ElektaNeuromag", "4DBti", "KitYokogawa", "ChietiItab", "Other"] },
-    "EEGCoordSys": { "type": "string", "enum": ["CapTrak", "Other"] },
+    "MEGCoordSys": {
+      "type": "string",
+      "enum": [
+        "CTF",
+        "ElektaNeuromag",
+        "4DBti",
+        "KitYokogawa",
+        "ChietiItab",
+        "Other"
+      ]
+    },
+    "EEGCoordSys": { "type": "string", "enum": ["CapTrak", "EEGLAB", "EEGLAB-HJ", "Other"] },
     "iEEGCoordSys": { "type": "string", "enum": ["Pixels", "ACPC", "Other"] },
-    "StandardTemplateCoordSys" :{
+    "StandardTemplateCoordSys": {
       "type": "string",
       "enum": [
         "ICBM452AirSpace",
@@ -32,8 +42,9 @@
         "OASIS30Atropos",
         "Talairach",
         "UNCInfant"
-        ] },
-    "StandardTemplateDeprecatedCoordSys" :{
+      ]
+    },
+    "StandardTemplateDeprecatedCoordSys": {
       "type": "string",
       "enum": [
         "fsaverage3",
@@ -50,7 +61,8 @@
         "UNCInfant0V23",
         "UNCInfant1V23",
         "UNCInfant2V23"
-        ] },
+      ]
+    },
     "DeviceSerialNumber": { "type": "string" },
     "ECGChannelCount": { "type": "integer", "minimum": 0 },
     "EEGChannelCount": { "type": "integer", "minimum": 0 },
@@ -88,11 +100,7 @@
     "RecordingDuration": { "type": "number" },
     "RecordingType": {
       "type": "string",
-      "enum": [
-        "continuous",
-        "epoched",
-        "discontinuous"
-      ]
+      "enum": ["continuous", "epoched", "discontinuous"]
     },
     "SamplingFrequency": { "type": "number" },
     "SoftwareFilters": {