Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add EEGLAB as a valid keyword for EEG coordsystems #1268

Merged
merged 3 commits into from
Apr 30, 2021
Merged

add EEGLAB as a valid keyword for EEG coordsystems #1268

merged 3 commits into from
Apr 30, 2021

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Apr 15, 2021 •
edited
Loading

@sappelhoff sappelhoff mentioned this pull request Apr 15, 2021
Merged
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #1268 (7ef8e88) into master (571767e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1268   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files          78       78           
  Lines        2682     2682           
  Branches      607      607           
=======================================
  Hits         2230     2230           
  Misses        365      365           
  Partials       87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571767e...7ef8e88. Read the comment docs.

@sappelhoff sappelhoff marked this pull request as ready for review April 30, 2021 08:12
@sappelhoff sappelhoff merged commit e9763df into bids-standard:master Apr 30, 2021
@sappelhoff sappelhoff deleted the eeglab branch April 30, 2021 08:12
rob-luke pushed a commit to rob-luke/bids-validator that referenced this pull request Jan 31, 2022
@sappelhoff @rob-luke
add EEGLAB as a valid keyword for EEG coordsystems (bids-standard#1268)
e4bfea1 
* add EEGLAB as a valid keyword for EEG coordsystems

* add EEGLAB-HJ

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sappelhoff