Build(deps): Bump bids-examples from ad9db4b to 4460013
#1080
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [bids-examples](https://github.com/bids-standard/bids-examples) from `ad9db4b` to `4460013`. - [Release notes](https://github.com/bids-standard/bids-examples/releases) - [Commits](bids-standard/bids-examples@ad9db4b...4460013) --- updated-dependencies: - dependency-name: bids-examples dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
There was a problem hiding this comment.
@effigies
shouldn't the validator tests be moved to the repo for the python bids validator?
There was a problem hiding this comment.
Yeah, probably. I didn't realize this is here. It's probably redundant with our existing tests...
There was a problem hiding this comment.
will cross check and maybe move the tests to the python bids-validator if necessary: may give me the occasion to be a bit familiar with that code base too.
There was a problem hiding this comment.
Would be a good idea. Incidentally, the problem with these tests seems to go back to the specification, where our regex generation is looser than the old hand-written ones. Thinking through how to manage this.
bids/layout/tests/test_validation.py
Outdated
| @@ -112,8 +112,8 @@ def test_is_session_level_true(testvalidator): | |||
|
|
|||
|
|
|||
| # checks is_session_level() function false cases | |||
| def test_is_session_level_false(testvalidator): | |||
| target_list = [ | |||
| @pytest.mark.parametrize("item", | |||
There was a problem hiding this comment.
parametrization to make it easier to know which test is failing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1080 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 63 63
Lines 7179 7174 -5
Branches 1374 1373 -1
=======================================
- Hits 6449 6445 -4
+ Misses 531 530 -1
Partials 199 199 ☔ View full report in Codecov by Sentry. |
| @@ -111,40 +111,6 @@ def test_is_session_level_true(testvalidator): | |||
| assert result | |||
|
|
|||
|
|
|||
| # checks is_session_level() function false cases | |||
There was a problem hiding this comment.
This should pass with the release of bidsschematools 0.11.0. Would you mind restoring it to verify? Then removing the tests can all be in #1081.
Bumps bids-examples from
ad9db4bto4460013.Commits
4460013Merge pull request #461 from effigies/fix/unused_sidecarsbf6144cfix: (Re)move sidecars with no data filesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)