-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"save" function not working besides provenance domain - could be clarification issue #113
Comments
Change button to "next" |
HadleyKing
added a commit
that referenced
this issue
Jul 11, 2023
Fix #110, Fix #113 Changes to be committed: modified: client/src/components/builder/components.js modified: client/src/components/builder/descriptionDomain.js modified: client/src/components/builder/extensionDomain.js modified: client/src/components/builder/index.js modified: client/src/components/builder/provenanceDomain.js modified: client/src/components/builder/usabilityDomain.js modified: client/src/components/home/index.js
HadleyKing
added a commit
that referenced
this issue
Jul 19, 2023
* Add Orcid User Info Api Fix biocompute-objects/playbook-partnership#16 Changes to be committed: modified: server/authentication/apis.py modified: server/authentication/services.py modified: server/authentication/urls.py * Typo fix Changes to be committed: modified: client/src/components/bcodbs/SearchOptions.js * Update services.py move `now = make_aware(datetime.utcnow())` to top * 1st round of changes Changes to be committed: modified: client/src/components/builder/index.js modified: client/src/components/builder/preview.js modified: client/src/components/viewer/cardViews.js modified: client/src/components/viewer/index.js modified: client/src/layouts/MainLayout/index.js * GA4 added * Security fixes (#115) * Add Orcid User Info Api Fix biocompute-objects/playbook-partnership#16 Changes to be committed: modified: server/authentication/apis.py modified: server/authentication/services.py modified: server/authentication/urls.py * Typo fix Changes to be committed: modified: client/src/components/bcodbs/SearchOptions.js * Update services.py move `now = make_aware(datetime.utcnow())` to top * 1st round of changes Changes to be committed: modified: client/src/components/builder/index.js modified: client/src/components/builder/preview.js modified: client/src/components/viewer/cardViews.js modified: client/src/components/viewer/index.js modified: client/src/layouts/MainLayout/index.js * GA4 added * Add resetToken API for server For biocompute-objects/bco_api#158 Changes to be committed: modified: server/bcodb/apis.py modified: server/bcodb/services.py modified: server/bcodb/urls.py * Token reset button for the client Fix biocompute-objects/bco_api#158 * Add functions for ORCID authentication Changes to be committed: modified: server/authentication/apis.py modified: server/authentication/services.py modified: server/authentication/urls.py modified: server/bcodb/services.py modified: server/users/apis.py * Add/Remove ORCID for UI Fix #90 Changes to be committed: modified: client/src/components/account/Profile.js modified: client/src/services/auth.service.js modified: client/src/slices/accountSlice.js * Add/Remove ORCID for server Fix #90 Changes to be committed: modified: server/authentication/apis.py modified: server/authentication/urls.py modified: server/bcodb/services.py --------- Co-authored-by: tianywan819 <[email protected]> * Icons portalupdate (#107) * GA4 added * For demostration use, updated GA4, updated Navigation header icons --------- Co-authored-by: tianywan819 <[email protected]> * Derive from Published Fix #118 Changes to be committed: modified: client/src/components/viewer/index.js modified: client/src/slices/bcoSlice.js * Implement Derive From Function Builder Fix #117 Changes to be committed: modified: client/src/components/builder/index.js modified: client/src/components/builder/provenanceDomain.js modified: client/src/components/viewer/index.js * Add XRefs to builder Changes to be committed: modified: client/src/components/builder/descriptionDomain.js modified: server/admin/db.sqlite3.dev modified: server/authentication/apis.py * Inaccurate modified time in Provenance Domain Fix #112 Changes to be committed: modified: client/src/components/builder/descriptionDomain.js modified: client/src/components/builder/executionDomain.js modified: client/src/components/builder/extensionDomain.js modified: client/src/components/builder/index.js modified: client/src/components/builder/ioDomain.js modified: client/src/components/builder/parametricDomain.js modified: client/src/components/builder/provenanceDomain.js modified: client/src/components/builder/rawJson.js renamed: client/src/components/builder/preview.js -> client/src/components/builder/treeView.js modified: client/src/components/builder/usabilityDomain.js modified: client/src/slices/bcoSlice.js * Next button (#128) * GA4 added * For demostration use, updated GA4, updated Navigation header icons * Changed all SAVE button to Next on the Builder page --------- Co-authored-by: tianywan819 <[email protected]> Co-authored-by: Hadley King <[email protected]> * Update domain buttons Fix #110, Fix #113 Changes to be committed: modified: client/src/components/builder/components.js modified: client/src/components/builder/descriptionDomain.js modified: client/src/components/builder/extensionDomain.js modified: client/src/components/builder/index.js modified: client/src/components/builder/provenanceDomain.js modified: client/src/components/builder/usabilityDomain.js modified: client/src/components/home/index.js --------- Co-authored-by: tianywan819 <[email protected]> Co-authored-by: Tianyi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
"save" function not clear. Need to indicate the save function only saves to the web browser but doesn't update the backend BCO. Need to click '''Update BCO''' to actually save the changes.
The text was updated successfully, but these errors were encountered: