Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: routing bug fix #1011

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: routing bug fix #1011

merged 1 commit into from
Dec 2, 2023

Conversation

Gumichocopengin8
Copy link
Contributor

Summary

Fixed routing bug.

Screen.Recording.2023-12-01.at.9.46.30.PM.mov

Test Plan

  • Change language to Japanese
  • Click はじめる button to route to the getting-started page
  • Check if the page is written in Japanese and the url is correct /ja/guides/getting-started

@netlify Netlify
Copy link

netlify bot commented Dec 2, 2023 •
edited
Loading

✅ Deploy Preview for rad-torte-839a59 ready!

Name Link
🔨 Latest commit 9974b94
🔍 Latest deploy log https://app.netlify.com/sites/rad-torte-839a59/deploys/656ac67faf47640008ef6668
😎 Deploy Preview https://deploy-preview-1011--rad-torte-839a59.netlify.app/ja
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gumichocopengin8 Gumichocopengin8 marked this pull request as ready for review December 2, 2023 05:54
@Gumichocopengin8 Gumichocopengin8 requested a review from a team as a code owner December 2, 2023 05:54
@github-actions github-actions bot added the A-Website Area: website label Dec 2, 2023
@Gumichocopengin8 Gumichocopengin8 mentioned this pull request Dec 2, 2023
Closed
nissy-dev
nissy-dev approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@nissy-dev nissy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@nissy-dev nissy-dev merged commit 02747d7 into biomejs:main Dec 2, 2023
7 checks passed
@Gumichocopengin8 Gumichocopengin8 deleted the fix/route branch December 2, 2023 08:32
yossydev pushed a commit to yossydev/biome that referenced this pull request Dec 3, 2023
@Gumichocopengin8
fix: routing bug fix (biomejs#1011)
85979c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nissy-dev nissy-dev nissy-dev approved these changes

Assignees
No one assigned
Labels
A-Website Area: website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gumichocopengin8 @nissy-dev