-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workspace): make types camel case #4368
Conversation
CodSpeed Performance ReportMerging #4368 will improve performances by 6.22%Comparing Summary
Benchmarks breakdown
|
4a9ce65
to
4eaaece
Compare
Should we also ensure that option values are in camel case? For now there are in Pascal Case in the playground. |
That's what I have been doing with this PR. Are there other options that I missed? |
I mean the values, not the names. For examples |
Yes, that's what the PR is for :) so, if you spot something that I missed, please do so! |
Should we not update biome/crates/biome_formatter/src/lib.rs Lines 123 to 130 in dc0b3ee
? To something like: impl Display for IndentStyle {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
IndentStyle::Tab => std::write!(f, "tab"),
IndentStyle::Space => std::write!(f, "space"),
}
}
} |
The display implementation isn't used in WASM, so we don't need to change it |
Co-authored-by: Arend van Beelen jr <[email protected]>
Summary
Closes #4366
All fields are now camel case.
This will break the playground, which means that we need to update it once
next
is merged tomain
Test Plan
I updated the JS APIs, CI should pass.