-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(ja): translate 404 page
into Japanese
#954
Conversation
404 page
into Japanese
Thank you for your contribution and investigating the problem! If there is some problems, I think there is no need to translate |
ok sure, but 404 page already has the issue https://biomejs.dev/fdsa (this page isn't a valid page so we expect to see 404 page, but not really). This PR might potentially fix the issue. Im fine with closing this PR anyways! |
Oh, I see. First, I try to check your vercel.json. If the PR is from a forked repository, preview-deploy job will not fire... |
Got it. we can close this PR and you or other core member can make a PR with the code, then we see the website preview. What do you think? |
I did in #956 And I don't know why, but the preview-deploy job ran in this PR, so I think we can confirm. |
It looks like the deployment is failing, can you confirm? |
yeah looks like vercel.json pattern is not correct. could you try with https://github.com/withastro/starlight/blob/8d88850c64928878dc7d63c3ec90756690da8387/docs/vercel.json#L20 which is suggested in this comment? I replace |
also, I'm not sure what is the right form to write PS: looks like Ci is not working from the forked repo as you said. CI worked cuz of your PR I guess? |
I think your work is valuable, but I would appreciate it if you could confirm preview-deploy job works well in a forked repository before submitting a PR. I don't want to spend much time debugging in this PR, so I'll close this PR. |
Summary
Partial work of #880. 404 page
Test Plan
I made an issue withastro/starlight#1154 about 404 page in starlight issue since 404 page is a special case. Looks like what we need to do to show 404 page is that make
ja/404.md
and setupvercel.json
. Not 100% sure if this would work so if we have the website preview, we should def check it out.