Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(ja): translate 404 page into Japanese #954

Closed

Conversation

Gumichocopengin8
Copy link
Contributor

@Gumichocopengin8 Gumichocopengin8 commented Nov 29, 2023

Summary

Partial work of #880. 404 page

Test Plan

I made an issue withastro/starlight#1154 about 404 page in starlight issue since 404 page is a special case. Looks like what we need to do to show 404 page is that make ja/404.md and setup vercel.json. Not 100% sure if this would work so if we have the website preview, we should def check it out.

@Gumichocopengin8 Gumichocopengin8 marked this pull request as ready for review November 29, 2023 09:32
@Gumichocopengin8 Gumichocopengin8 requested a review from a team as a code owner November 29, 2023 09:32
@github-actions github-actions bot added the A-Website Area: website label Nov 29, 2023
@Gumichocopengin8 Gumichocopengin8 changed the title doc(ja): translate 404 page into Japanese doc(ja): translate 404 page into Japanese Nov 29, 2023
@nissy-dev
Copy link
Contributor

Thank you for your contribution and investigating the problem!

If there is some problems, I think there is no need to translate 404.md.
I'm very sorry, but I'll close this PR and update task list in #880.

@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Nov 29, 2023

ok sure, but 404 page already has the issue https://biomejs.dev/fdsa (this page isn't a valid page so we expect to see 404 page, but not really). This PR might potentially fix the issue. Im fine with closing this PR anyways!

@nissy-dev
Copy link
Contributor

ok sure, but 404 page already has the issue https://biomejs.dev/fdsa (this page isn't a valid page so we expect to see 404 page, but not really).

Oh, I see. First, I try to check your vercel.json. If the PR is from a forked repository, preview-deploy job will not fire...

@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Nov 29, 2023

ok sure, but 404 page already has the issue https://biomejs.dev/fdsa (this page isn't a valid page so we expect to see 404 page, but not really).

Oh, I see. First, I try to check your vercel.json. If the PR is from a forked repository, preview-deploy job will not fire...

Got it. we can close this PR and you or other core member can make a PR with the code, then we see the website preview. What do you think?

@nissy-dev
Copy link
Contributor

nissy-dev commented Nov 29, 2023

we can close this PR and you or other core member can make a PR with the code, then we see the website preview. What do you think?

I did in #956 And I don't know why, but the preview-deploy job ran in this PR, so I think we can confirm.

@nissy-dev
Copy link
Contributor

It looks like the deployment is failing, can you confirm?

@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Nov 29, 2023

yeah looks like vercel.json pattern is not correct. could you try with https://github.com/withastro/starlight/blob/8d88850c64928878dc7d63c3ec90756690da8387/docs/vercel.json#L20 which is suggested in this comment? I replace routes with rewrite cuz routes is not recommended anymore but for the testing purpose, we can use that one. Let me also push the new commit here in case the CI works.

@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented Nov 29, 2023

also, I'm not sure what is the right form to write vercel.json specifically for Starlight. I asked a question about this. until we get a response, we might need to try several times. If you or other contributors think it's not worth it, I dont mind skipping this task.


PS: looks like Ci is not working from the forked repo as you said. CI worked cuz of your PR I guess?

@nissy-dev
Copy link
Contributor

nissy-dev commented Nov 29, 2023

also, I'm not sure what is the right form to write vercel.json specifically for Starlight. I asked a question about this. until we get a response, we might need to try several times. If you or other contributors think it's not worth it, I dont mind skipping this task.

I think your work is valuable, but I would appreciate it if you could confirm preview-deploy job works well in a forked repository before submitting a PR. I don't want to spend much time debugging in this PR, so I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Website Area: website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants