Refactor desktop Closed Tradable model utils for API #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move some potentially sharable utility code from desktop's ClosedTrade models to core's new ClosedTradeUtil. The API's `gettrades --category=<open|closed|failed>` method will need some of this logic on the server side, but the scope of this refactoring is larger in the interest of a more complete refactor, and avoiding duplication in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some potentially shareable utility code from desktop's ClosedTrade models to core's new
ClosedTradeUtil.The API's
gettrades --category=<open|closed|failed>method will need some of this logic on the server side, but the scope of the refactoring is larger in the interest of completeness, and avoiding duplication in the future.This PR's branch is based off
master, and is not part of any PR chain requiring review/merge of any parent PRs.