Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 30 #941

Closed
ghubstan opened this issue Nov 15, 2021 · 6 comments
Closed

For Cycle 30 #941

ghubstan opened this issue Nov 15, 2021 · 6 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ghubstan
Copy link
Member

ghubstan commented Nov 15, 2021

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 4180.80
  • USD requested: 7400
  • BSQ rate: 1.77 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 28 #911

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Add API support to Atomic-Swap devel (PR to @sqrrm's repo) dev 1500 sqrrm/bisq-desktop#4 @sqrrm will confirm my assistance with atomic/swap
Call keepfunds (close trade) on both sides of trade simulation dev 0 bisq-network/bisq#5708 merged
Let API user set currencies in some payment account json forms dev 750 bisq-network/bisq#5685 merged
CLI bug fix: show trade`s contract volume, not moving offer volume dev 0 bisq-network/bisq#5704 merged
Add custom bisq.properties to API test harness dev 100 bisq-network/bisq#5718 merged
Move volume formatting from DisplayUtils to VolumeUtil dev 100 bisq-network/bisq#5740 merged
Refactor desktop Closed Tradable model utils for API dev 350 bisq-network/bisq#5743 merged
Remove apitest create bsq-swap account method dev 100 bisq-network/bisq#5811 merged
Deprecate and replace hard-coded CLI console output formatters dev 2500 bisq-network/bisq#5812 merged
Review/Test BSQ Swap PR 5769 dev 250 bisq-network/bisq#5769 merged
Review/Test BSQ Swap PR 5770 dev 750 bisq-network/bisq#5770 merged
Review/Test BSQ Swap PR 5775 dev 1000 bisq-network/bisq#5775 merged

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Link Notes
API 'getoffer' & 'gettrade' support for BSQ swaps bisq-network/bisq#5827 awaiting review

Will re-work and submit XMR/BTC trading pair support in API (original PRs closed due to BSQ swap priorities).

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Nov 15, 2021
@ripcurlx
Copy link
Contributor

@sqrrm If you have time could you give your 👍 for @ghubstan support in sqrrm/bisq-desktop#4?

As dev team lead I approve the remaining tasks.

@MwithM MwithM added this to the Cycle 30 milestone Nov 16, 2021
@sqrrm
Copy link
Member

sqrrm commented Nov 20, 2021

I approve the work I have reviewed and been involved with, perhaps @chimp1984 could approve the other work.

@chimp1984
Copy link

ACK

@ghubstan
Copy link
Member Author

e9f9622f275f30a86ec59a3d4abf3a1ac5d105df5e065aba4f8d0d248301e1c6

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 2, 2021
@ghost
Copy link

ghost commented Dec 2, 2021

Issuance by Team:

team amount BSQ amount USD
dev 4180.80 7400.00

Total Issuance: 4180.80 BSQ (equivalent to: 7400.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Dec 2, 2021

Closed as accepted

@MwithM MwithM closed this as completed Dec 2, 2021
@ghubstan ghubstan mentioned this issue Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants