Add atomic offer/trade support to API #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add offers service protos: GetAtomicOffer, GetMyAtomicOffer, GetAtomicOffers, GetMyAtomicOffers, CreateAtomicOffer. - Add proto message AtomicOfferInfo. - Add bool tradeAtomic field to CreateCryptoCurrencyPaymentAccountRequest. - Add trades service protos: GetAtomicTrade, TakeAtomicOffer. - Add proto message AtomicTradeInfo.
sqrrm
pushed a commit
that referenced
this pull request
Dec 16, 2022
…o-volume-to-string Change API OfferInfo volume/minVolume proto fields to string [#4]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicOfferTestandAtomicTradeTestcan be used to debug new api.AtomicTradeTestLoopcan be used to debug wallet inconsistency problems.To run Bob & Alice daemons in debug mode, change the flag in
AbstractOfferTest, line 61.Alice remote debug port:
49998Bob remote debug port:
49999