-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change alias to not substitute the same alias recursively #630
Labels
Comments
shyguy1412
added a commit
to shyguy1412/bitburner-src
that referenced
this issue
Jun 20, 2023
shyguy1412
added a commit
to shyguy1412/bitburner-src
that referenced
this issue
Jun 20, 2023
shyguy1412
added a commit
to shyguy1412/bitburner-src
that referenced
this issue
Jun 20, 2023
Snarling
pushed a commit
that referenced
this issue
Jun 20, 2023
This was partially addressed by #635 but we may want to do more of a rewrite to provide full recursion-detection (instead of just checking the most recent alias substitution) |
ficocelliguy
added a commit
to ficocelliguy/bitburner-src
that referenced
this issue
Aug 21, 2023
ficocelliguy
added a commit
to ficocelliguy/bitburner-src
that referenced
this issue
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of now (dev build included),
alias
doesn't behave like POSIX spec says.It naively repeats substitution 10 times if a recursive loop is found.
POSIX spec however mentions:
source
The current implementation can create a situation like the following (thank you, Noxebo on Discord):
How to resolve:
keep track of the last used alias, and if the same alias is used again directly after, don't substitute.
The text was updated successfully, but these errors were encountered: