UI: Prevent recursive aliases from being resolved. Fixes bitburner-official#630 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the max depth check? I think the origin of that was just to prevent recursive replacements, but if you're already preventing recursive replacements then aliases should just continue to replace until there are no more non-recursive replacements to make. e.g. if a=b, b=c, c=d [...] y=z, then |
|
I had left in the max depth as a bit of a failsafe (and in case it was an existing feature). I have removed it and updated the unit tests accordingly. |
G4mingJon4s
pushed a commit
to G4mingJon4s/bitburner-src
that referenced
this pull request
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor alias processing: when resolving an alias, look at the tracked list of previously-processed aliases that led to the current one, and do not resolve any
aliaiialiases already present in it. This ensures there are no loops in the alias reference tree in a given command, and replaces the current only-one-alias-lookback solution.closes #630