Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10137] Update SDK to a6987cf and Xcode to 15.4 #767

Closed
wants to merge 3 commits into from

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Jul 29, 2024

🎟️ Tracking

PM-10137

📔 Objective

Update SDK reference to a6987cf34e6ec7456f2f55f14b794bdb8ba1f368.

Also for this to happen we need to bump the Xcode version to use to 15.4 which is aligned with the default one in Github actions runner image.

Includes:

Notes:
Updated some snapshots for Xcode 15.4 to the tests pass.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…f368. Also updated XCode to 15.4 in CI as it's required by the SDK update and consequently updated the snapshot for this version of XCode.
@fedemkr fedemkr requested review from matt-livefront and a team July 29, 2024 15:19
Copy link
Contributor

@KatherineInCode KatherineInCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Only thought is that I could see splitting this into two PRs: one for the Xcode update itself, and then another for the SDK update

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details3fa608cc-4b90-4f3f-81c1-eec3f1f203a0

No New Or Fixed Issues Found

@fedemkr
Copy link
Member Author

fedemkr commented Jul 29, 2024

This will be splitted into two PRs so the Test workflow doesn't fail.

@fedemkr fedemkr closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants