[PM-9527] Add PIN validation support #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
+ Coverage 57.92% 58.07% +0.15%
==========================================
Files 193 194 +1
Lines 13120 13194 +74
==========================================
+ Hits 7600 7663 +63
- Misses 5520 5531 +11 ☔ View full report in Codecov by Sentry. |
Hinton
reviewed
Jul 19, 2024
|
|
||
| match login_method { | ||
| UserLoginMethod::Username { email, kdf, .. } | ||
| | UserLoginMethod::ApiKey { email, kdf, .. } => { |
There was a problem hiding this comment.
question: Do we expect Api key logins to use pin?
There was a problem hiding this comment.
I don't think so, and I'm not sure if they would need password validation either. I think this is mostly a case of copying over the match to get email and kdf. We can return an error for ApiKey if you prefer though.
Hinton
approved these changes
Jul 19, 2024
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9527
📔 Objective
Fede mentioned on Slack some time ago that we currently don't have a simple way to validate the user's PIN like we do with the password. Instead the way to do it was to call
init_cryptoand check that the result is not an error.This requires more data than needed and does a lot of unnecessary operations, so I think it makes sense to expose a simpler way to do PIN verification.
In this PR we're decrypting the PIN protected user key and comparing it with the stored user key, similar to what we're doing with
validate_password_user_key.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes