Sm 989 create build pipeline for the python language wrapper #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangowithfoxtrot
added a commit
that referenced
this pull request
Dec 6, 2023
## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [x] Build/deploy pipeline (DevOps) - [x] Other ## Objective Rename the Python package. This should be merged before #369. ## Code changes - **`languages/python/setup.py`:** Rename package - **`languages/python/bitwarden_sdk`:** Rename directory to match package name - **`.gitignore`:** Changed path to `schemas.py` - **`.github/workflows/generate_schemas.yml`:** Changed path to `schemas.py` ## Before you submit - Please add **unit tests** where it makes sense to do so (encouraged but not required)
python3 bin does not exist on newer container images
…for-the-python-language-wrapper
This reverts commit 85490df.
…r-the-python-language-wrapper
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 48.64% 49.34% +0.69%
==========================================
Files 152 154 +2
Lines 7277 7373 +96
==========================================
+ Hits 3540 3638 +98
+ Misses 3737 3735 -2 ☔ View full report in Codecov by Sentry. |
dani-garcia
reviewed
Jan 8, 2024
tangowithfoxtrot
changed the title
Thomas-Avery
requested changes
Jan 10, 2024
Thomas-Avery
approved these changes
Jan 10, 2024
michalchecinski
approved these changes
Jan 11, 2024
tangowithfoxtrot
deleted the
SM-989-create-build-and-publish-pipelines-for-the-python-language-wrapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Package the Python SDK so that it can be published to PyPI.org.
Code changes
.github/workflows/build-python-wheels.yml: create wheels for Linux, macOS, and Windows (AMD64-only). A sdist is also created for other platforms.languages/python/BitwardenClient/__init__.py: export functions and classes for autocompletion in IDEs and the interactive Python interpreterlanguages/python/pyproject.toml: replacessetup.py, which is no longer officially supported. This uses Maturin to build the Rust shared-object library that will be bundled with the SDK.languages/python/setup.py: replaced bypyproject.tomlBefore you submit