rename Python package to bitwarden_sdk
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
vgrassia
approved these changes
Dec 5, 2023
|
The CI seems to be failing. |
|
It's failing because the |
tangowithfoxtrot
deleted the
sm/SM-1025/Rename-Python-package-to-bitwarden_sdk
branch
5 tasks
tangowithfoxtrot
added a commit
that referenced
this pull request
Dec 6, 2023
## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fix broken schema generation workflow from #399. ## Code changes - **./support/scripts/schemas.ts:** Update the Python schemas dir ## Before you submit - Please add **unit tests** where it makes sense to do so (encouraged but not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Rename the Python package. This should be merged before #369.
Code changes
languages/python/setup.py: Rename packagelanguages/python/bitwarden_sdk: Rename directory to match package name.gitignore: Changed path toschemas.py.github/workflows/generate_schemas.yml: Changed path toschemas.pyBefore you submit