[PM-4269] Use rustls on non-wasm platforms #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hinton
reviewed
Dec 1, 2023
|
No New Or Fixed Issues Found |
5 tasks
Hinton
reviewed
Dec 7, 2023
dani-garcia
changed the title
dani-garcia
changed the title
Hinton
previously approved these changes
Dec 14, 2023
dani-garcia
changed the title
Hinton
previously approved these changes
Jan 8, 2024
# Conflicts: # Cargo.lock # crates/bws/Cargo.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 48.60% 48.64% +0.04%
==========================================
Files 152 152
Lines 7271 7277 +6
==========================================
+ Hits 3534 3540 +6
Misses 3737 3737 ☔ View full report in Codecov by Sentry. |
Hinton
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Updated reqwest to use rustls on all platforms. We're also using rustls-platform-verifier where possible to load the CA certificates from the operating system store instead of including them in the binary.
Note that WASM doesn't need a TLS stack as reqwest just uses the browser's
fetch