Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken schema generation #403

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix broken schema generation #403

merged 1 commit into from
Dec 6, 2023

Conversation

tangowithfoxtrot
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix broken schema generation workflow from #399.

Code changes

  • ./support/scripts/schemas.ts: Update the Python schemas dir

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@tangowithfoxtrot tangowithfoxtrot requested a review from a team December 6, 2023 19:08
Thomas-Avery
Thomas-Avery approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangowithfoxtrot tangowithfoxtrot merged commit 030e842 into master Dec 6, 2023
39 of 40 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the fix-broken-schema-generation branch December 6, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Avery Thomas-Avery Thomas-Avery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tangowithfoxtrot @Thomas-Avery