Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SM-815: Switch Command Order #76

Merged
merged 3 commits into from
Jun 24, 2023
Merged

SM-815: Switch Command Order #76

merged 3 commits into from
Jun 24, 2023

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Jun 21, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Switch the command order for the bws cli. Instead of bws create secret, move to a more logical bws secret create structure.

We have left the existing commands but have removed them from the help menu and marked them as deprecated.

Code changes

  • main.rs: Update command order

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@coltonhurst coltonhurst self-assigned this Jun 21, 2023
Hinton
Hinton reviewed Jun 22, 2023
View reviewed changes
crates/bws/src/main.rs Outdated Show resolved Hide resolved
@coltonhurst coltonhurst requested a review from Hinton June 23, 2023 17:45
Hinton
Hinton approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks.

@coltonhurst coltonhurst merged commit 4d03abd into master Jun 24, 2023
@coltonhurst coltonhurst deleted the sm/SM-815 branch June 24, 2023 14:45
@coltonhurst coltonhurst mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

@dani-garcia dani-garcia Awaiting requested review from dani-garcia

Assignees

@coltonhurst coltonhurst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coltonhurst @Hinton