Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-807: BWS CLI & SDK Updates #77

Merged
merged 18 commits into from
Jul 21, 2023
Merged

SM-807: BWS CLI & SDK Updates #77

merged 18 commits into from
Jul 21, 2023

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Jun 26, 2023

Type of change

- [x] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR covers the following items:

  • project_id is now a required argument when creating a secret.
  • Editing a secret was broken due to not handling the list of project id’s correctly. This has been fixed.
  • A user is now able to update the project a secret is in if they choose to.
  • The SecretCommand edit now allows multiple options to be set at the same time. This was forgotten on the initial command order change (link).
  • Proper error messaging has been added in the case that none, some, or all secret / project deletions fail

Error messages when deleting projects or secrets now follow this template:

X project(s) deleted successfully.
X project(s) had an error:
{id of project}: {server error message}

Line 1 should always print. Lines 2 and 3 should only print if there were any errors.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@coltonhurst coltonhurst self-assigned this Jun 26, 2023
@coltonhurst coltonhurst changed the title SM-807: BWS CLI & SDK Read / Write Updates SM-807: BWS CLI & SDK Updates Jun 26, 2023
@coltonhurst coltonhurst marked this pull request as ready for review June 27, 2023 11:52
crates/bws/src/main.rs Show resolved Hide resolved
crates/bws/src/main.rs Outdated Show resolved Hide resolved
crates/bws/src/main.rs Outdated Show resolved Hide resolved
@coltonhurst coltonhurst requested a review from Hinton June 28, 2023 13:40
crates/bws/src/main.rs Outdated Show resolved Hide resolved
@coltonhurst coltonhurst requested a review from Hinton June 29, 2023 15:04
Hinton
Hinton previously approved these changes Jun 29, 2023
dani-garcia
dani-garcia previously approved these changes Jul 5, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Jul 10, 2023

Logo
Checkmarx One – Scan Summary & Detailsc80778ac-9177-4996-bac0-f17f144f66ae

No New Or Fixed Issues Found

Hinton
Hinton previously approved these changes Jul 12, 2023
@coltonhurst coltonhurst merged commit 0a5ff9c into master Jul 21, 2023
31 checks passed
@coltonhurst coltonhurst deleted the sm/SM-807 branch July 21, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants