[SM-1371] Expose a new generate_secret function #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 57.98% 57.96% -0.02%
==========================================
Files 197 197
Lines 13647 13651 +4
==========================================
Hits 7913 7913
- Misses 5734 5738 +4 ☔ View full report in Codecov by Sentry. |
mzieniukbw
previously approved these changes
Aug 21, 2024
coltonhurst
changed the title
mzieniukbw
approved these changes
Aug 23, 2024
dani-garcia
approved these changes
Aug 23, 2024
tangowithfoxtrot
approved these changes
Aug 23, 2024
coltonhurst
added a commit
that referenced
this pull request
Aug 23, 2024
## 🎟️ Tracking https://bitwarden.atlassian.net/browse/SM-1371 ## 📔 Objective Add a `GenerateSecret` function to the Go SDK. **Note** this depends on the #986 PR, which should be merged first. This PR is parallel to this: #937. One will be merged and the other closed based on the decided approach. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
Hinton
reviewed
Aug 26, 2024
Comment on lines
+94
to
+98
| pub mod generators { | ||
| pub use bitwarden_generators::{ | ||
| password, ClientGeneratorExt, PasswordError, PasswordGeneratorRequest, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Any reason to put this under the secrets manager module instead of exposing generators like we do for the internal feature?
There was a problem hiding this comment.
No specific reason. Thinking more about it, refactoring it to this is probably a better approach going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1371
📔 Objective
Exposes the
passwordgenerator function for generating secrets.This PR also fixes typos in
crates/bitwarden-generators/src/password.rs.Alternate solution with an abstraction layer between SM and Bitwarden core generation functionality: #936
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes