-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1371] Add GeneratePassword to the Go SDK #992
Conversation
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 57.96% 57.96%
=======================================
Files 197 197
Lines 13651 13651
=======================================
Hits 7913 7913
Misses 5738 5738 ☔ View full report in Codecov by Sentry. |
AvoidAmbiguous: true, | ||
Length: 64, | ||
Lowercase: true, | ||
MinLowercase: new(int64), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new(int64) is 0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just putting it in there as an example
The base branch was changed.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1371
📔 Objective
Add a
GeneratePassword
function to the Go SDK.Note this depends on the #986 PR, which should be merged first.
This PR is parallel to this: #937. One will be merged and the other closed based on the decided approach.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes