Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1371] Add GeneratePassword to the Go SDK #992

Merged
merged 11 commits into from
Aug 23, 2024
Merged

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Aug 23, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1371

📔 Objective

Add a GeneratePassword function to the Go SDK.

Note this depends on the #986 PR, which should be merged first.

This PR is parallel to this: #937. One will be merged and the other closed based on the decided approach.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst changed the base branch from main to sm/sm-1371_parta August 23, 2024 03:12
@coltonhurst coltonhurst self-assigned this Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Logo
Checkmarx One – Scan Summary & Details24966ee4-599c-4c3c-8000-6d574f9d0fc1

No New Or Fixed Issues Found

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.96%. Comparing base (5afe12b) to head (36e7c0d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files         197      197           
  Lines       13651    13651           
=======================================
  Hits         7913     7913           
  Misses       5738     5738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mzieniukbw
mzieniukbw previously approved these changes Aug 23, 2024
AvoidAmbiguous: true,
Length: 64,
Lowercase: true,
MinLowercase: new(int64),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new(int64) is 0 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just putting it in there as an example

dani-garcia
dani-garcia previously approved these changes Aug 23, 2024
Base automatically changed from sm/sm-1371_parta to main August 23, 2024 13:54
@coltonhurst coltonhurst dismissed stale reviews from tangowithfoxtrot, dani-garcia, and mzieniukbw August 23, 2024 13:54

The base branch was changed.

@coltonhurst coltonhurst merged commit f682554 into main Aug 23, 2024
61 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1371_partb branch August 23, 2024 14:13
@coltonhurst coltonhurst changed the title [SM-1371] Add GenerateSecret to the Go SDK [SM-1371] Add GeneratePassword to the Go SDK Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants