-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1371] Add GeneratePassword to the Go SDK #992
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
44d98f5
SM-1371: Expose a new generate_secret function
coltonhurst 01cccdf
Merge branch 'main' into sm/sm-1371_parta
coltonhurst fee210f
SM-1371: Add response to sdk-schemas
coltonhurst 5488062
SM-1371: Switch to using password retaining the name
coltonhurst 47b2993
SM-1371: Resolve doc links issue
coltonhurst 6ff7534
SM-1371: Add bitwarden-generators as a dep for secrets feature
coltonhurst 0b259df
Merge branch 'main' into sm/sm-1371_parta
coltonhurst ea460e2
SM-1371: Update scopes
coltonhurst 8f6544f
SM-1371: Fix bad imports
coltonhurst d85419e
SM-1371: Add generators() and GeneratePassword() with example to Go Sโฆ
coltonhurst 36e7c0d
Merge branch 'main' into sm/sm-1371_partb
coltonhurst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package sdk | ||
|
||
type GeneratorsInterface interface { | ||
GeneratePassword(request PasswordGeneratorRequest) (*string, error) | ||
} | ||
|
||
type Generators struct { | ||
CommandRunner CommandRunnerInterface | ||
} | ||
|
||
func NewGenerators(commandRunner CommandRunnerInterface) *Generators { | ||
return &Generators{CommandRunner: commandRunner} | ||
} | ||
|
||
func (s *Generators) executeCommand(command Command, target interface{}) error { | ||
responseStr, err := s.CommandRunner.RunCommand(command) | ||
if err != nil { | ||
return err | ||
} | ||
return checkSuccessAndError(responseStr, target) | ||
} | ||
|
||
func (s *Generators) GeneratePassword(request PasswordGeneratorRequest) (*string, error) { | ||
command := Command{ | ||
Generators: &GeneratorsCommand{ | ||
GeneratePassword: request, | ||
}, | ||
} | ||
|
||
var response string | ||
if err := s.executeCommand(command, &response); err != nil { | ||
return nil, err | ||
} | ||
return &response, nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new(int64) is 0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just putting it in there as an example