-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MASVS initial commit, ASVS kbID correction, closes #348, local installation and db_tools fixes. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this changes the user can input international characters like á, ì and ç.
Correction of the Checklist Order on a Sprint. Before: 1.1, 1.10, 1.2 Now: 1.1, 1.2, 1.10
Correction of unused variable and "Redefining built-in 'list'" Codacy issues.
Order requirements in checklist page
Now on the Failed requirements page, there is a button to export that requirements to Defect Dojo.
Buttons hidding or not acordint to checklist status in Project-Summary.
Fixed Codacy issues of #430
Fix of error introduced by Codacy issue.
Fix of issue in which only admin can create projects and sprints.
Using observable in Angular (thanks RiieCco) with finally making the call for the new list.
Added some controls in the UI according to privileges of the user. Added select on Create User option. Fix of issue with privileges.query without privilegeID, that returns every privilege in login action.
Added level to requirements on ASVS modal. Fixes issue 347
Added checklist level to modal header
Initial commit of MASVS Checklist. Fixed some exceptions in db_tools when db.sqlite_schema doesn't exist.
…ments. - Added MASVS levels to checklist_component.html which allows to see this levels in checklist view. - Put correct kbID to some ASVS files that were different from checklists_kb (1.4, 2.27, 2.32, 8.6, 8.11, 9.2). - Added message 'Initialized the markdown checklists.' if init_md_checklists goes OK. - Added Exception messages when update_db or init_db throws one.
Upload of Local folder and instructions for running a local instance of SKF.
Fix of bug when pressing on the empty category line. Added documentation and replaces (perl -pi -e...) in entrypoint.sh
ASVS shows in checklists page. Missing description of items.
Corrections of failing test that are related to checklists
Code Quality issue from previous PL
New issues and possible new issues.
Codacy issue...
Fix weird unit test failures
blabla1337
approved these changes
Feb 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the improvements, looks good
blabla1337
pushed a commit
that referenced
this pull request
Mar 8, 2018
* Internationalization With this changes the user can input international characters like á, ì and ç. * Sprint Checklist in correct Order Correction of the Checklist Order on a Sprint. Before: 1.1, 1.10, 1.2 Now: 1.1, 1.2, 1.10 * Correction of Codacy Issues Correction of unused variable and "Redefining built-in 'list'" Codacy issues. * Order in checklist page Order requirements in checklist page * Export failed requirement to Defect Dojo Now on the Failed requirements page, there is a button to export that requirements to Defect Dojo. * Buttons hidding acording to status Buttons hidding or not acordint to checklist status in Project-Summary. * Fixed Codacy issues of #430 Fixed Codacy issues of #430 * Error fix. Fix of error introduced by Codacy issue. * Codacy fix * Fix of issue #422 Fix of issue in which only admin can create projects and sprints. * Fix reordening issue 428 Using observable in Angular (thanks RiieCco) with finally making the call for the new list. * Codacy fixes * Added privileges control in UI and user-add Added some controls in the UI according to privileges of the user. Added select on Create User option. Fix of issue with privileges.query without privilegeID, that returns every privilege in login action. * Added level to requirements on ASVS modal Added level to requirements on ASVS modal. Fixes issue 347 * Added checklist level to modal header Added checklist level to modal header * MASVS Checklist items and db_tools except fixes. Initial commit of MASVS Checklist. Fixed some exceptions in db_tools when db.sqlite_schema doesn't exist. * Added MASVS levels to checklist view, ASVS fixes and db_tools improvements. - Added MASVS levels to checklist_component.html which allows to see this levels in checklist view. - Put correct kbID to some ASVS files that were different from checklists_kb (1.4, 2.27, 2.32, 8.6, 8.11, 9.2). - Added message 'Initialized the markdown checklists.' if init_md_checklists goes OK. - Added Exception messages when update_db or init_db throws one. * Fix issue #348 Add empty category message * Local installation Upload of Local folder and instructions for running a local instance of SKF. * ASVS empty fix, and local install https Fix of bug when pressing on the empty category line. Added documentation and replaces (perl -pi -e...) in entrypoint.sh * MASVS checklist ASVS shows in checklists page. Missing description of items. * Test corrections for PL #440 Corrections of failing test that are related to checklists * Old code Quality issue Code Quality issue from previous PL * Some Codacy issues. New issues and possible new issues. * Codacy issue... Codacy issue... * Update db_tools.py Fix weird unit test failures * Entrypoint extra fi deletion Deletion of extra fi on entrypoint.sh
blabla1337
pushed a commit
that referenced
this pull request
Mar 10, 2018
* Internationalization With this changes the user can input international characters like á, ì and ç. * Sprint Checklist in correct Order Correction of the Checklist Order on a Sprint. Before: 1.1, 1.10, 1.2 Now: 1.1, 1.2, 1.10 * Correction of Codacy Issues Correction of unused variable and "Redefining built-in 'list'" Codacy issues. * Order in checklist page Order requirements in checklist page * Export failed requirement to Defect Dojo Now on the Failed requirements page, there is a button to export that requirements to Defect Dojo. * Buttons hidding acording to status Buttons hidding or not acordint to checklist status in Project-Summary. * Fixed Codacy issues of #430 Fixed Codacy issues of #430 * Error fix. Fix of error introduced by Codacy issue. * Codacy fix * Fix of issue #422 Fix of issue in which only admin can create projects and sprints. * Fix reordening issue 428 Using observable in Angular (thanks RiieCco) with finally making the call for the new list. * Codacy fixes * Added privileges control in UI and user-add Added some controls in the UI according to privileges of the user. Added select on Create User option. Fix of issue with privileges.query without privilegeID, that returns every privilege in login action. * Added level to requirements on ASVS modal Added level to requirements on ASVS modal. Fixes issue 347 * Added checklist level to modal header Added checklist level to modal header * MASVS Checklist items and db_tools except fixes. Initial commit of MASVS Checklist. Fixed some exceptions in db_tools when db.sqlite_schema doesn't exist. * Added MASVS levels to checklist view, ASVS fixes and db_tools improvements. - Added MASVS levels to checklist_component.html which allows to see this levels in checklist view. - Put correct kbID to some ASVS files that were different from checklists_kb (1.4, 2.27, 2.32, 8.6, 8.11, 9.2). - Added message 'Initialized the markdown checklists.' if init_md_checklists goes OK. - Added Exception messages when update_db or init_db throws one. * Fix issue #348 Add empty category message * Local installation Upload of Local folder and instructions for running a local instance of SKF. * ASVS empty fix, and local install https Fix of bug when pressing on the empty category line. Added documentation and replaces (perl -pi -e...) in entrypoint.sh * MASVS checklist ASVS shows in checklists page. Missing description of items. * Test corrections for PL #440 Corrections of failing test that are related to checklists * Old code Quality issue Code Quality issue from previous PL * Some Codacy issues. New issues and possible new issues. * Codacy issue... Codacy issue... * Update db_tools.py Fix weird unit test failures * Entrypoint extra fi deletion Deletion of extra fi on entrypoint.sh * Kb items corrections This closes #399, closes #416, closes #400, closes #261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit of MASVS Checklist.
Added message when empty category on checklist level.
Fixed some exceptions in db_tools when db.sqlite_schema doesn't exist.
Upload of Local folder and instructions for running a local instance of SKF.