Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kb items corrections #442

Merged
merged 39 commits into from
Mar 10, 2018
Merged

Kb items corrections #442

merged 39 commits into from
Mar 10, 2018

Conversation

martinmarsicano
Copy link
Collaborator

This fixes #399 , fixes #416 , fixes #400 , fixes #407 .

With this changes the user can input international characters like á, ì and ç.
Correction of the Checklist Order on a Sprint.
Before: 1.1, 1.10, 1.2
Now: 1.1, 1.2, 1.10
Correction of unused variable and "Redefining built-in 'list'" Codacy issues.
Order requirements in checklist page
Now on the Failed requirements page, there is a button to export that requirements to Defect Dojo.
Buttons hidding or not acordint to checklist status in Project-Summary.
Fixed Codacy issues of #430
Fix of error introduced by Codacy issue.
Fix of issue in which only admin can create projects and sprints.
Using observable in Angular (thanks RiieCco) with finally making the call for the new list.
Added some controls in the UI according to privileges of the user.
Added select on Create User option.

Fix of issue with privileges.query without privilegeID, that returns every privilege in login action.
Added level to requirements on ASVS modal. Fixes issue 347
Added checklist level to modal header
Initial commit of MASVS Checklist.
Fixed some exceptions in db_tools when db.sqlite_schema doesn't exist.
…ments.

- Added MASVS levels to checklist_component.html which allows to see this levels in checklist view.
- Put correct kbID to some ASVS files that were different from checklists_kb (1.4, 2.27, 2.32, 8.6, 8.11, 9.2).
- Added message 'Initialized the markdown checklists.' if init_md_checklists goes OK.
- Added Exception messages when update_db or init_db throws one.
Add empty category message
Upload of Local folder and instructions for running a local instance of SKF.
Fix of bug when pressing on the empty category line.

Added documentation and replaces (perl -pi -e...) in entrypoint.sh
ASVS shows in checklists page.
Missing description of items.
martinmarsicano and others added 9 commits February 28, 2018 12:17
Corrections of failing test that are related to checklists
Code Quality issue from previous PL
New issues and possible new issues.
Codacy issue...
Fix weird unit test failures
Deletion of extra fi on entrypoint.sh
This closes #399, closes #416, closes #400, closes #261
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.419% when pulling dbbb742 on martinmarsicano:master into ff36161 on blabla1337:master.

@codecov
Copy link

codecov bot commented Mar 10, 2018

Codecov Report

Merging #442 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files          33       33           
  Lines         778      778           
  Branches       81       81           
=======================================
  Hits          515      515           
  Misses        188      188           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff36161...dbbb742. Read the comment docs.

Copy link
Owner

@blabla1337 blabla1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the polish Martin!

@blabla1337 blabla1337 merged commit 06d6614 into blabla1337:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor knowledebase item 88 KB item 261 is empty Refactor KB item 193 refactor KB item 131
3 participants