Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kb items corrections #442

Merged
merged 39 commits into from
Mar 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
bea6d6b
Internationalization
martinmarsicano Jan 26, 2018
e01af09
Sprint Checklist in correct Order
martinmarsicano Jan 28, 2018
f70399a
Correction of Codacy Issues
martinmarsicano Jan 28, 2018
01e505d
Order in checklist page
martinmarsicano Jan 29, 2018
8681a16
Merge remote-tracking branch 'upstream/master'
martinmarsicano Jan 29, 2018
0b04f8b
Export failed requirement to Defect Dojo
martinmarsicano Jan 31, 2018
2ee3799
Merge remote-tracking branch 'upstream/master'
martinmarsicano Jan 31, 2018
d52f3ff
Merge remote-tracking branch 'upstream/master'
martinmarsicano Feb 3, 2018
91e133a
Buttons hidding acording to status
martinmarsicano Feb 3, 2018
b799f1a
Fixed Codacy issues of #430
martinmarsicano Feb 3, 2018
4a5a8ba
Error fix.
martinmarsicano Feb 3, 2018
96b6079
Codacy fix
martinmarsicano Feb 3, 2018
278aa06
Fix of issue #422
martinmarsicano Feb 3, 2018
67b3c91
Merge remote-tracking branch 'upstream/master'
martinmarsicano Feb 3, 2018
45f0fb2
Fix reordening issue 428
martinmarsicano Feb 5, 2018
d12862d
Merge remote-tracking branch 'upstream/master'
martinmarsicano Feb 5, 2018
d88b680
Codacy fixes
martinmarsicano Feb 5, 2018
4519dc6
Merge remote-tracking branch 'upstream/master'
martinmarsicano Feb 5, 2018
4953126
Added privileges control in UI and user-add
martinmarsicano Feb 5, 2018
5ead09e
Added level to requirements on ASVS modal
martinmarsicano Feb 13, 2018
ad51ca6
Merge remote-tracking branch 'upstream/master'
martinmarsicano Feb 13, 2018
95e86af
Merge remote-tracking branch 'upstream/master'
martinmarsicano Feb 13, 2018
f111cdd
Added checklist level to modal header
martinmarsicano Feb 13, 2018
dd3bf18
Merge remote-tracking branch 'upstream/master'
martinmarsicano Feb 24, 2018
409ba5f
MASVS Checklist items and db_tools except fixes.
martinmarsicano Feb 24, 2018
a21d43f
Added MASVS levels to checklist view, ASVS fixes and db_tools improve…
martinmarsicano Feb 25, 2018
8548001
Fix issue #348
martinmarsicano Feb 26, 2018
c46ed1e
Local installation
martinmarsicano Feb 26, 2018
24c7069
ASVS empty fix, and local install https
martinmarsicano Feb 26, 2018
438af2e
MASVS checklist
martinmarsicano Feb 26, 2018
265e937
Test corrections for PL #440
martinmarsicano Feb 28, 2018
546bc66
Old code Quality issue
martinmarsicano Feb 28, 2018
c3dbc1d
Some Codacy issues.
martinmarsicano Feb 28, 2018
37d9b19
Codacy issue...
martinmarsicano Feb 28, 2018
f02b4bf
Update db_tools.py
blabla1337 Feb 28, 2018
ac04131
Entrypoint extra fi deletion
martinmarsicano Mar 8, 2018
b5f54ac
Merge remote-tracking branch 'upstream/master'
martinmarsicano Mar 8, 2018
6ae8c6b
Kb items corrections
martinmarsicano Mar 10, 2018
dbbb742
Merge remote-tracking branch 'upstream/master'
martinmarsicano Mar 10, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
## Description:

Use this kind of HTTP headers such as a bearer token only if you have authenticated the server sending the header to your application.
There are some kind of headers that uses tokens such as Bearer or JWT which are signed or calculated using a key, by the server that creates it.

## Solution:

Verify that HTTP headers added by a trusted proxy or SSO devices, such as a bearer token, are
authenticated by the application.
Verify the integrity and authenticity of the HTTP headers added by a trusted proxy or SSO devices by checking the digital signature or by recalculating the hash or integrity method using a private key or passphrase.
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

There are some security headers which should be properly configured in order to protect some API callbacks against Reflective File Download and other type of injections.

Also check that the API response is not dynamic, if so use input validation and encoding in order to prevent XSS and Same origin method execution attacks.
Also check if the API response is dynamic, if user input is reflected in the response. If so, you must validate and encode the input, in order to prevent XSS and Same origin method execution attacks.

## Solution:

Verify that all API responses contain X-Content-Type-Options: nosniff and Content-Disposition: attachment; filename="api.json" (or other appropriate filename for the content type).
Sanitize your API's input (in this case they should just allow alphanumeric); escaping is not sufficient

Verify that all API responses contain X-Content-Type-Options: nosniff, to prevent the browser from interpreting files as something else than declared by the content type (this helps prevent XSS if the page is interpreted as html or js).

Add 'Content-Disposition: attachment; filename="filename.extension"' with extension corresponding the file extension and content-type, on APIs that are not going to be rendered

Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
## Description:

Some data on an application can be consider sensitive due to its importance:
- Social security number
- Credit card or banking information
Or by the context of the information:
- Passphrase used as a password of an application
- University restricted or critical data

On applications, data considered sensitive should be kept safe. The way we secure the data could be defined by us, but some information it should be made according to a standard - i.e. all applications that manipulate credit card information should comply with one of the pci standards.


## Solution:

Identify the list of sensitive data that is being processed by the application.

Establish, maintain, and disseminate a security policy for processing and storing sensitive data. If information should be encrypted, separated in another database, etc. If exist, follow the appropriate standard.
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
## Description:

This is a mitigation of the risk that a password can leak by any means towards a possible attacker.Changing the password to a new one minimizes the damage.
This is a mitigation of the risk that a password can leak by any means towards a possible attacker. Because of password reuse, this could happen not only due to a leak in your site. Changing the password to a new one minimizes the damage.

Also, users really don't like changing their passwords. So what users used to do when forced to change their password was to change it twice - once to some temporary password and then a second time back to the original password.

## Solution:

Keep the old entries of the password record of the user. If the user changes his password
you can match against the old entries to validate it is not an old one.
Keep a number of password hashes entries greater than the number of times that the change password functionality execution is permitted and validate that the new password hash is not one of those entries.