Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Stylings referencing fa-* not applied after sky-icon switch #1983

Closed
Blackbaud-TrevorBurch opened this issue Sep 12, 2018 · 1 comment
Closed

Stylings referencing fa-* not applied after sky-icon switch #1983

Blackbaud-TrevorBurch opened this issue Sep 12, 2018 · 1 comment
Assignees
@Blackbaud-TrevorBurch
Labels
Severity: High Status: Ready to merge Type: Bug

Comments

@Blackbaud-TrevorBurch
Copy link
Member

After we switched all icons to use sky-icon there are a few instances of styles that referenced fa-* classes directly that are now not being applied. These were most likely missed due to the change being smaller than the visual test threshold.
@Blackbaud-TrevorBurch
Copy link
Member Author

Blackbaud-TrevorBurch commented Sep 12, 2018 •
edited
Loading

It appears this is affecting:

  • link-records
  • list-secondary-actions
  • modal

@blackbaud-conorwright blackbaud-conorwright self-assigned this Sep 12, 2018
Merged
Blackbaud-TrevorBurch added a commit that referenced this issue Sep 19, 2018
@Blackbaud-TrevorBurch
Fixed missed icons and styles referencing the old icons (#1987)
8a29a0a 
Resolves #1983
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch

Labels
Severity: High Status: Ready to merge Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Blackbaud-TrevorBurch @blackbaud-conorwright