This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed missed icons and styles referencing the old icons #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackbaud-conorwright
suggested changes
Sep 12, 2018
| <i | ||
| class="fa fa-lg" | ||
| [ngClass]="['fa-' + buttonType]"></i> | ||
| <sky-icon [icon]="buttonType" size="lg"></sky-icon> |
There was a problem hiding this comment.
Multiple line attributes 😉
This applies to the other files too. I don't want to clutter with one kind of style comment
…3-icon-style-issues
blackbaud-conorwright
suggested changes
Sep 14, 2018
blackbaud-conorwright
approved these changes
Sep 14, 2018
…3-icon-style-issues
Codecov Report
@@ Coverage Diff @@
## master #1987 +/- ##
==========================================
+ Coverage 99.94% 99.94% +<.01%
==========================================
Files 423 423
Lines 9266 9296 +30
Branches 1384 1391 +7
==========================================
+ Hits 9261 9291 +30
Misses 5 5
Continue to review full report at Codecov.
|
|
I removed all old modal screenshots as the fixed font size of the close button was causing a couple to fail consistently on the build machine (they passed locally but I'm guessing it was a resolution thing). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1983