Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Fullscreen Popover Closing #1985

Merged
merged 10 commits into from
Sep 19, 2018
Merged

Conversation

Blackbaud-TrevorBurch
Copy link
Member

Resolves #1504

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-ToddRoberts would you mind to give this a look? Thanks!

@Blackbaud-ToddRoberts
Copy link
Contributor

Close button should be the same as it is on Modal. Looks a few px too large here.

@Blackbaud-TrevorBurch
Copy link
Member Author

Hey @Blackbaud-ToddRoberts there is a small difference in this PR due to a styling on the modal's close button being lost when the icon components were pulled out. That is fixed in #1987 and that PR will bring the modal's close button back to having a font-size of 20px as it was prior to 2.23.0 when the mistake in the icon switchover brought it down to 15px.

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective, this LGTM!

@codecov-io
Copy link

codecov-io commented Sep 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@952b694). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1985   +/-   ##
=========================================
  Coverage          ?   99.94%           
=========================================
  Files             ?      423           
  Lines             ?     9298           
  Branches          ?     1391           
=========================================
  Hits              ?     9293           
  Misses            ?        5           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/popover/popover.module.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952b694...922d8ba. Read the comment docs.

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch merged commit 299bc05 into master Sep 19, 2018
@Blackbaud-TrevorBurch Blackbaud-TrevorBurch deleted the 1504-fullscreen-popover-close branch September 19, 2018 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants