-
Notifications
You must be signed in to change notification settings - Fork 65
Conversation
@Blackbaud-ToddRoberts would you mind to give this a look? Thanks! |
Close button should be the same as it is on Modal. Looks a few px too large here. |
Hey @Blackbaud-ToddRoberts there is a small difference in this PR due to a styling on the modal's close button being lost when the icon components were pulled out. That is fixed in #1987 and that PR will bring the modal's close button back to having a font-size of 20px as it was prior to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective, this LGTM!
…4-fullscreen-popover-close and fixed issues with full screen popovers that didn't have a title.
Codecov Report
@@ Coverage Diff @@
## master #1985 +/- ##
=========================================
Coverage ? 99.94%
=========================================
Files ? 423
Lines ? 9298
Branches ? 1391
=========================================
Hits ? 9293
Misses ? 5
Partials ? 0
Continue to review full report at Codecov.
|
Resolves #1504