Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check length of signer addresses #489

Merged
merged 1 commit into from
Mar 9, 2019
Merged

check length of signer addresses #489

merged 1 commit into from
Mar 9, 2019

Conversation

rickyyangz
Copy link
Contributor

Description

verify the signer addresses in ante handler

Rationale

we should limit the address length to 20

Example

Changes

Notable changes:
*

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@rickyyangz rickyyangz changed the base branch from master to develop March 9, 2019 05:31
@rickyyangz rickyyangz merged commit d8bcc1d into develop Mar 9, 2019
@rickyyangz rickyyangz mentioned this pull request Mar 9, 2019
Merged
4 tasks
@unclezoro unclezoro deleted the addrlen branch May 10, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackratos ackratos ackratos approved these changes

@darren-liu darren-liu darren-liu approved these changes

@yutianwu yutianwu Awaiting requested review from yutianwu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickyyangz @ackratos @darren-liu