[Merged by Bors] - Fix string.prototype methods and add static string methods #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
- Coverage 55.75% 55.67% -0.08%
==========================================
Files 201 201
Lines 17273 17375 +102
==========================================
+ Hits 9631 9674 +43
- Misses 7642 7701 +59
Continue to review full report at Codecov.
|
Test262 conformance changes:
Numbers look pretty good. |
RageKnify
approved these changes
Feb 8, 2021
HalidOdat
reviewed
Feb 15, 2021
Razican
approved these changes
May 10, 2021
|
Current numbers, I'll try to understand if I accidentaly introduced the 32 panics. Test262 conformance changes:
Fixed tests:New panics: |
|
I'm not getting panics locally, I'll run test262 again. Test262 conformance changes:
Fixed tests:Broken tests:New panics: |
|
I'm able to reproduce the panics locally: |
|
@jevancc It would be very nice to get this merged. Did you have the chance to review the panics & re-base it? |
Sure, I will complete it soon this week. |
|
@Razican This PR has been rebased to the latest main. Update notes:
Feel free to merge this PR if everything looks good to you or let me know if there are other changes required before merging. |
Test262 conformance changesVM implementation
Fixed tests (114):Broken tests (2):New panics (32): |
|
Let's give this a look. It looks pretty good, but we must fix the panics before merging. |
Razican
reviewed
Feb 14, 2022
|
VM implementation
Fixed tests (138):Broken tests (2): |
jevancc
force-pushed
the
static-string-methods
branch
from
54681ca
to
f29121d
Compare
Test262 conformance changesVM implementation
Fixed tests (138): |
The panic is triggered by surrogates as parameters to fromCodePoint. I fixed them by replacing these chars with a replacement character. This problem will not be solvable until we have the UTF-16 support. |
Razican
approved these changes
Feb 15, 2022
|
LGTM! Thank you for all the work :) bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes existing string prototype methods in #13 and adds static methods. It changes the following: - Fix bugs in existing string prototype methods and improve readability (e.g. rename variables to match the names in spec) - Add static methods `String.raw`, `String.fromCharCode`, `String.fromCodePoint` - Fix broken unit tests Co-authored-by: RageKnify <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
With the implementation of `String.fromCodePoint` in #1123 some `RegExp` tests are now running for a long time. These tests check every unicode codepoint for all regexp property escape/character classes. This not only makes the developer experience significantly worse, but also wastes cpu resources for the benefit of "completeness". I think these tests are completely useless. Ironically the unicode tables in the tests are generated - from the same data, that the unicode tables in the regex engine are also generated. 262 suite runtime: Before: ~03:30 https://github.com/boa-dev/boa/runs/5191567446?check_suite_focus=true After: ~31:00 https://github.com/boa-dev/boa/runs/5196405437?check_suite_focus=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes existing string prototype methods in #13 and adds static methods.
It changes the following:
String.raw,String.fromCharCode,String.fromCodePoint