Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix string.prototype methods and add static string methods #1123

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - Fix string.prototype methods and add static string methods #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
8044760
Add fromCharCode
jevancc Feb 6, 2021
e4ceba1
Add fromCodePoint
jevancc Feb 6, 2021
c112659
Add String.raw
jevancc Feb 6, 2021
3911f17
Fix broken tests
jevancc Feb 7, 2021
41df390
Fix and refactor string.prototype methods
jevancc Feb 7, 2021
03a2d08
Fix infinite loop bug
jevancc Feb 7, 2021
21128f2
Fix string length bugs
jevancc Feb 8, 2021
9ab2157
Fix unsafe add
jevancc Feb 8, 2021
31458d3
Update boa/src/builtins/string/mod.rs
jevancc Feb 17, 2021
be0708c
Merge remote-tracking branch 'upstream/master' into static-string-met…
jevancc Feb 17, 2021
3e49ebc
Remove outdated comments
jevancc Feb 17, 2021
9dfdffd
Merge branch 'master' into static-string-methods
RageKnify Jun 6, 2021
0a4d921
Style: Respect rustfmt
RageKnify Jun 6, 2021
c60d883
Merge branch 'main' into static-string-methods
jevancc Feb 12, 2022
0b89512
Merge branch 'main' into static-string-methods
jevancc Feb 13, 2022
ad90e0b
Fix merge conflicts
jevancc Feb 13, 2022
c9c4a94
Fix clippy
jevancc Feb 13, 2022
cb926e2
Update test262
jevancc Feb 13, 2022
83a9e32
Fix rustfmt
jevancc Feb 13, 2022
4f6a323
Add spec steps comments and remove unwrap
jevancc Feb 14, 2022
f29121d
Fix panics with replacement char workaround
jevancc Feb 15, 2022
b011da8
Fix a bug in lastIndexOf
jevancc Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boa/src/builtins/regexp/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,7 +1760,7 @@ fn advance_string_index(s: &JsString, index: usize, unicode: bool) -> usize {

// 5. Let cp be ! CodePointAt(S, index).
let (_, offset, _) =
crate::builtins::string::code_point_at(s, index as i32).expect("Failed to get code point");
crate::builtins::string::code_point_at(s, index as i64).expect("Failed to get code point");

index + offset as usize
}
Loading