Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Symbol builtin #1234

Merged
merged 1 commit into from
May 8, 2021
Merged

Separate Symbol builtin #1234

merged 1 commit into from
May 8, 2021

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Move non-builtin symbol stuff to symbol module
  • Move RcSymbol from value module to symbol module

This is done so we don't mix the builtin Symbol stuff with the way we store Symbol. like #689

@github-actions
Copy link

github-actions bot commented May 7, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 25,537 25,537 0
Ignored 15,587 15,587 0
Failed 37,373 37,373 0
Panics 13 14 +1
Conformance 32.53 32.53 0.00%

@github-actions
Copy link

github-actions bot commented May 7, 2021

Benchmark for e933b6e

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 391.6±43.24ns 384.9±12.34ns +1.74%
Arithmetic operations (Full) 269.4±19.55µs 259.9±12.54µs +3.66%
Array access (Execution) 6.5±0.42µs 6.5±0.29µs 0.00%
Array access (Full) 292.0±45.22µs 286.1±48.72µs +2.06%
Array creation (Execution) 2.9±0.12ms 2.9±0.11ms 0.00%
Array creation (Full) 3.4±0.18ms 3.4±0.12ms 0.00%
Array pop (Execution) 950.8±33.54µs 963.1±37.62µs -1.28%
Array pop (Full) 1482.0±72.09µs 1466.1±66.06µs +1.08%
Boolean Object Access (Execution) 5.6±0.26µs 5.6±0.25µs 0.00%
Boolean Object Access (Full) 279.9±12.81µs 283.9±22.86µs -1.41%
Clean js (Execution) 701.4±37.44µs 691.3±20.91µs +1.46%
Clean js (Full) 1018.4±51.73µs 1012.6±46.80µs +0.57%
Clean js (Parser) 43.1±1.92µs 43.0±1.92µs +0.23%
Create Realm 451.5±24.96ns 449.0±16.77ns +0.56%
Dynamic Object Property Access (Execution) 5.4±0.24µs 5.4±0.31µs 0.00%
Dynamic Object Property Access (Full) 282.3±12.59µs 279.4±11.69µs +1.04%
Expression (Parser) 7.1±0.55µs 7.2±0.83µs -1.39%
Fibonacci (Execution) 821.0±33.16µs 815.9±29.28µs +0.63%
Fibonacci (Full) 1099.6±63.74µs 1106.5±62.30µs -0.62%
For loop (Execution) 23.7±0.89µs 24.0±4.39µs -1.25%
For loop (Full) 304.6±15.64µs 306.8±14.61µs -0.72%
For loop (Parser) 20.9±1.68µs 20.6±0.92µs +1.46%
Goal Symbols (Parser) 14.5±0.56µs 14.6±1.03µs -0.68%
Hello World (Parser) 4.0±0.17µs 4.1±0.42µs -2.44%
Long file (Parser) 818.1±29.51ns 827.2±26.76ns -1.10%
Mini js (Execution) 631.6±40.14µs 624.7±24.27µs +1.10%
Mini js (Full) 934.4±26.06µs 952.6±40.05µs -1.91%
Mini js (Parser) 37.6±2.60µs 37.3±2.79µs +0.80%
Number Object Access (Execution) 4.3±0.34µs 4.3±0.21µs 0.00%
Number Object Access (Full) 272.3±11.26µs 271.5±10.13µs +0.29%
Object Creation (Execution) 4.5±0.29µs 4.7±0.79µs -4.26%
Object Creation (Full) 275.0±14.47µs 273.5±13.15µs +0.55%
RegExp (Execution) 12.3±0.49µs 12.3±0.50µs 0.00%
RegExp (Full) 284.9±16.51µs 284.3±10.40µs +0.21%
RegExp Literal (Execution) 12.5±1.17µs 12.3±0.64µs +1.63%
RegExp Literal (Full) 290.9±31.54µs 290.0±13.29µs +0.31%
RegExp Literal Creation (Execution) 11.1±0.88µs 10.8±0.55µs +2.78%
RegExp Literal Creation (Full) 278.9±15.37µs 280.3±11.12µs -0.50%
Static Object Property Access (Execution) 4.8±0.31µs 4.7±0.27µs +2.13%
Static Object Property Access (Full) 284.0±16.69µs 274.6±11.00µs +3.42%
String Object Access (Execution) 7.7±0.40µs 7.7±0.39µs 0.00%
String Object Access (Full) 283.5±10.71µs 285.8±14.06µs -0.80%
String comparison (Execution) 6.9±0.44µs 6.7±0.31µs +2.99%
String comparison (Full) 285.7±21.84µs 281.9±11.79µs +1.35%
String concatenation (Execution) 5.7±0.28µs 5.6±0.23µs +1.79%
String concatenation (Full) 271.9±9.09µs 277.6±20.54µs -2.05%
String copy (Execution) 4.2±0.18µs 4.2±0.29µs 0.00%
String copy (Full) 267.6±12.61µs 269.4±13.52µs -0.67%
Symbols (Execution) 3.5±0.16µs 3.5±0.23µs 0.00%
Symbols (Full) 258.8±12.35µs 262.7±13.45µs -1.48%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) just needs a re-base.

@github-actions
Copy link

github-actions bot commented May 8, 2021

Benchmark for 0619ac2

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 329.2±13.23ns 333.7±12.05ns -1.35%
Arithmetic operations (Full) 238.7±6.78µs 244.6±11.24µs -2.41%
Array access (Execution) 6.2±0.33µs 6.0±0.23µs +3.33%
Array access (Full) 267.5±13.84µs 284.3±26.89µs -5.91%
Array creation (Execution) 2.6±0.07ms 2.6±0.12ms 0.00%
Array creation (Full) 2.9±0.09ms 2.9±0.11ms 0.00%
Array pop (Execution) 827.5±27.13µs 833.6±33.75µs -0.73%
Array pop (Full) 1285.4±48.85µs 1284.4±58.17µs +0.08%
Boolean Object Access (Execution) 5.1±0.23µs 5.1±0.27µs 0.00%
Boolean Object Access (Full) 265.4±19.39µs 263.6±9.92µs +0.68%
Clean js (Execution) 633.4±26.94µs 638.4±24.36µs -0.78%
Clean js (Full) 919.6±41.63µs 915.2±46.38µs +0.48%
Clean js (Parser) 39.8±3.27µs 38.9±2.33µs +2.31%
Create Realm 410.8±34.69ns 409.5±20.98ns +0.32%
Dynamic Object Property Access (Execution) 5.3±0.38µs 5.2±0.35µs +1.92%
Dynamic Object Property Access (Full) 261.5±12.21µs 269.4±10.79µs -2.93%
Expression (Parser) 6.4±0.31µs 6.2±0.33µs +3.23%
Fibonacci (Execution) 820.9±26.11µs 835.5±45.85µs -1.75%
Fibonacci (Full) 1065.0±37.43µs 1059.8±36.20µs +0.49%
For loop (Execution) 21.9±1.19µs 21.7±0.96µs +0.92%
For loop (Full) 279.7±12.17µs 283.5±13.44µs -1.34%
For loop (Parser) 18.4±0.83µs 18.4±0.66µs 0.00%
Goal Symbols (Parser) 12.6±0.49µs 12.8±0.46µs -1.56%
Hello World (Parser) 3.5±0.20µs 3.5±0.18µs 0.00%
Long file (Parser) 731.3±24.37ns 743.9±34.73ns -1.69%
Mini js (Execution) 565.1±31.04µs 560.3±25.04µs +0.86%
Mini js (Full) 849.8±38.22µs 860.9±74.19µs -1.29%
Mini js (Parser) 34.4±2.67µs 34.0±1.84µs +1.18%
Number Object Access (Execution) 4.2±0.24µs 4.0±0.14µs +5.00%
Number Object Access (Full) 256.0±10.53µs 264.0±12.17µs -3.03%
Object Creation (Execution) 4.4±0.16µs 4.4±0.16µs 0.00%
Object Creation (Full) 259.0±10.17µs 269.5±15.53µs -3.90%
RegExp (Execution) 10.6±0.32µs 10.7±0.45µs -0.93%
RegExp (Full) 267.0±12.89µs 278.7±22.76µs -4.20%
RegExp Literal (Execution) 10.6±0.43µs 10.7±0.58µs -0.93%
RegExp Literal (Full) 270.2±11.89µs 276.2±13.96µs -2.17%
RegExp Literal Creation (Execution) 9.5±0.36µs 9.2±0.39µs +3.26%
RegExp Literal Creation (Full) 263.6±12.44µs 280.7±39.76µs -6.09%
Static Object Property Access (Execution) 4.5±0.16µs 4.5±0.15µs 0.00%
Static Object Property Access (Full) 262.8±10.70µs 270.7±10.03µs -2.92%
String Object Access (Execution) 7.1±0.35µs 7.2±0.35µs -1.39%
String Object Access (Full) 263.4±13.66µs 271.1±9.66µs -2.84%
String comparison (Execution) 6.3±0.31µs 6.5±0.47µs -3.08%
String comparison (Full) 265.6±14.23µs 266.1±11.43µs -0.19%
String concatenation (Execution) 5.3±0.47µs 5.3±0.28µs 0.00%
String concatenation (Full) 258.9±12.70µs 259.5±10.15µs -0.23%
String copy (Execution) 4.1±0.24µs 3.9±0.23µs +5.13%
String copy (Full) 259.1±11.79µs 256.7±10.90µs +0.93%
Symbols (Execution) 3.4±0.16µs 3.4±0.18µs 0.00%
Symbols (Full) 242.4±14.54µs 245.9±13.15µs -1.42%

@HalidOdat HalidOdat merged commit db3b6c5 into master May 8, 2021
@HalidOdat HalidOdat deleted the separate-symbol-builtin branch May 8, 2021 23:07
Razican pushed a commit that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants