Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move object module to root #689

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Move object module to root #689

merged 1 commit into from
Sep 8, 2020

Conversation

HalidOdat
Copy link
Member

Same as #674

It changes the following:

  • Move object module (only the non-buitin stuff) to root
  • Abstract global object Object methods to a struct (like all the other objects, so there not free functions

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics API labels Sep 7, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Sep 7, 2020
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #689 into master will decrease coverage by 0.07%.
The diff coverage is 34.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   71.78%   71.70%   -0.08%     
==========================================
  Files         198      199       +1     
  Lines       13852    13863      +11     
==========================================
- Hits         9944     9941       -3     
- Misses       3908     3922      +14     
Impacted Files Coverage Δ
boa/src/builtins/array/mod.rs 76.65% <ø> (ø)
boa/src/builtins/bigint/mod.rs 70.00% <ø> (ø)
boa/src/builtins/boolean/mod.rs 36.66% <ø> (ø)
boa/src/builtins/date/mod.rs 56.45% <ø> (ø)
boa/src/builtins/date/tests.rs 99.18% <ø> (ø)
boa/src/builtins/error/mod.rs 32.00% <ø> (ø)
boa/src/builtins/error/range.rs 77.27% <ø> (ø)
boa/src/builtins/error/reference.rs 77.27% <ø> (ø)
boa/src/builtins/error/syntax.rs 59.09% <ø> (ø)
boa/src/builtins/error/type.rs 77.27% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edfafc4...02464cd. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 7, 2020

Benchmark for 55f800b

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 386.3±22.61ns 357.3±39.46ns +8.12%
Arithmetic operations (Full) 236.1±12.34µs 251.5±26.00µs -6.12%
Array access (Execution) 8.9±0.67µs 8.3±0.92µs +7.23%
Array access (Full) 292.1±17.83µs 276.7±27.86µs +5.57%
Array creation (Execution) 3.5±0.19ms 3.1±0.35ms +12.90%
Array creation (Full) 3.5±0.20ms 3.4±0.26ms +2.94%
Array pop (Execution) 1264.0±88.00µs 1086.2±82.84µs +16.37%
Array pop (Full) 1598.1±85.40µs 1600.1±162.66µs -0.12%
Boolean Object Access (Execution) 5.2±0.35µs 4.6±0.37µs +13.04%
Boolean Object Access (Full) 281.6±26.13µs 258.2±22.39µs +9.06%
Clean js (Execution) 772.6±53.38µs 716.7±69.05µs +7.80%
Clean js (Full) 1026.9±109.75µs 1005.2±98.85µs +2.16%
Clean js (Parser) 36.8±4.45µs 36.8±4.30µs 0.00%
Create Realm 498.1±37.71ns 450.7±45.55ns +10.52%
Dynamic Object Property Access (Execution) 6.1±0.45µs 5.4±0.36µs +12.96%
Dynamic Object Property Access (Full) 289.4±22.15µs 273.4±20.85µs +5.85%
Expression (Parser) 6.7±0.73µs 6.3±0.49µs +6.35%
Fibonacci (Execution) 938.9±47.58µs 866.8±86.29µs +8.32%
Fibonacci (Full) 1258.3±211.74µs 1201.0±142.97µs +4.77%
For loop (Execution) 24.5±2.24µs 21.8±1.53µs +12.39%
For loop (Full) 320.6±20.01µs 291.5±30.82µs +9.98%
For loop (Parser) 18.0±1.95µs 17.5±1.82µs +2.86%
Goal Symbols (Parser) 11.5±0.89µs 11.7±1.14µs -1.71%
Hello World (Parser) 3.0±0.32µs 3.0±0.27µs 0.00%
Long file (Parser) 752.4±59.39ns 777.5±76.71ns -3.23%
Mini js (Execution) 708.8±50.90µs 650.1±72.31µs +9.03%
Mini js (Full) 908.2±80.06µs 940.6±91.53µs -3.44%
Mini js (Parser) 31.5±3.37µs 32.7±3.34µs -3.67%
Number Object Access (Execution) 4.0±0.36µs 3.7±0.39µs +8.11%
Number Object Access (Full) 259.0±24.97µs 263.2±25.09µs -1.60%
Object Creation (Execution) 5.2±0.47µs 4.6±0.44µs +13.04%
Object Creation (Full) 289.0±22.68µs 273.9±28.33µs +5.51%
RegExp (Execution) 77.4±6.78µs 71.0±8.03µs +9.01%
RegExp (Full) 340.2±44.76µs 374.4±43.54µs -9.13%
RegExp Literal (Execution) 77.8±6.02µs 72.3±8.42µs +7.61%
RegExp Literal (Full) 364.8±34.96µs 348.5±36.98µs +4.68%
RegExp Literal Creation (Execution) 76.2±5.52µs 66.5±6.09µs +14.59%
RegExp Literal Creation (Full) 361.9±26.76µs 338.0±36.18µs +7.07%
Static Object Property Access (Execution) 5.6±0.44µs 5.2±0.56µs +7.69%
Static Object Property Access (Full) 296.5±22.05µs 277.6±31.12µs +6.81%
String Object Access (Execution) 7.7±0.62µs 6.8±0.48µs +13.24%
String Object Access (Full) 264.7±23.88µs 275.2±28.08µs -3.82%
String comparison (Execution) 7.1±0.68µs 6.5±0.75µs +9.23%
String comparison (Full) 269.3±28.14µs 275.5±32.41µs -2.25%
String concatenation (Execution) 5.6±0.43µs 5.2±0.52µs +7.69%
String concatenation (Full) 260.1±24.92µs 265.9±27.11µs -2.18%
String copy (Execution) 4.3±0.33µs 3.8±0.31µs +13.16%
String copy (Full) 262.2±27.13µs 257.9±25.26µs +1.67%
Symbols (Execution) 3.5±0.28µs 3.1±0.24µs +12.90%
Symbols (Full) 256.6±22.59µs 239.4±22.83µs +7.18%

@Razican Razican merged commit efd9ab8 into master Sep 8, 2020
@HalidOdat HalidOdat deleted the move-object-module branch September 8, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants