Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exec/expression into exec/call and exec/new #529

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Refactor exec/expression into exec/call and exec/new #529

merged 1 commit into from
Jul 3, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jun 25, 2020 •
edited
Loading

Minor refactor. Also added BoaProfiled to impl Executable for New

@croraf croraf changed the title Refactor exec/expression. Add BoaProfiled to Executable for New Refactor exec/expression into exec/call and exec/new. Add BoaProfiled to Executable for New Jun 25, 2020
@croraf croraf changed the title Refactor exec/expression into exec/call and exec/new. Add BoaProfiled to Executable for New Refactor exec/expression into exec/call and exec/new Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #529 into master will decrease coverage by 0.00%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
- Coverage   68.10%   68.09%   -0.01%     
==========================================
  Files         169      170       +1     
  Lines        9942     9943       +1     
==========================================
  Hits         6771     6771              
- Misses       3171     3172       +1
Impacted Files Coverage Δ
boa/src/exec/call/mod.rs 68.96% <ø> (ø)
boa/src/exec/new/mod.rs 73.33% <73.33%> (ø)
boa/src/exec/mod.rs 66.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a652a...daf075b. Read the comment docs.

@croraf croraf mentioned this pull request Jun 27, 2020
Closed
Razican
Razican approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. I guess we can move the New to a new module, don't see why not.

boa/src/exec/new/mod.rs Show resolved Hide resolved
@Razican Razican added this to the v0.10.0 milestone Jul 2, 2020
@Razican Razican added enhancement New feature or request execution Issues or PRs related to code execution labels Jul 2, 2020
@Razican Razican merged commit 641dce1 into boa-dev:master Jul 3, 2020
@croraf croraf mentioned this pull request Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@croraf @Razican @HalidOdat