Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ast/node/expression into ast/node/call and ast/node/new #542

Closed
wants to merge 2 commits into from

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jul 3, 2020

It makes no sense to leave these two grouped under the node expression.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #542 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   68.33%   68.33%           
=======================================
  Files         172      173    +1     
  Lines       10495    10495           
=======================================
  Hits         7172     7172           
  Misses       3323     3323           
Impacted Files Coverage Δ
boa/src/exec/call/mod.rs 68.96% <ø> (ø)
boa/src/exec/new/mod.rs 73.33% <ø> (ø)
boa/src/syntax/ast/node/call.rs 53.84% <ø> (ø)
boa/src/syntax/ast/node/mod.rs 17.94% <ø> (ø)
boa/src/syntax/ast/node/new.rs 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641dce1...b4351e0. Read the comment docs.

@RageKnify
Copy link
Member

Please resolve the conflicts when you can @croraf

@croraf
Copy link
Contributor Author

croraf commented Oct 2, 2020

This is standing here 3 months, and was such a trivial change. :|

@croraf
Copy link
Contributor Author

croraf commented Oct 4, 2020

Not possible to resolve conflicts.
I will make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants